Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile CGUs #89568

Closed
wants to merge 2 commits into from
Closed

Profile CGUs #89568

wants to merge 2 commits into from

Conversation

Sl1mb0
Copy link
Contributor

@Sl1mb0 Sl1mb0 commented Oct 5, 2021

Will eventually resolve #89308.

r? @Mark-Simulacrum

@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2021
@Sl1mb0 Sl1mb0 changed the title Added event kind for cgu names Add support for profiling CGUs Oct 5, 2021
@rust-log-analyzer

This comment has been minimized.

@Sl1mb0 Sl1mb0 changed the title Add support for profiling CGUs Profile CGUs Oct 5, 2021
Changed field name

Changed field name

Added event kinds for cgu names and tracking merges
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@jackh726 jackh726 assigned Mark-Simulacrum and unassigned jackh726 Oct 5, 2021
@bors
Copy link
Contributor

bors commented Oct 20, 2021

☔ The latest upstream changes (presumably #90067) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2021
@Mark-Simulacrum
Copy link
Member

Going to mark as waiting on author for now, but please let me know if you'd like a review (@rustbot ready).

@Sl1mb0
Copy link
Contributor Author

Sl1mb0 commented Oct 28, 2021

Hey sorry I posted all this and just stopped. I have been really busy and plan on getting to this as soon as I have the time.

@Dylan-DPC
Copy link
Member

Thanks for contributing. I'm closing this since it's inactive and seems you might not have the time to get back to it. Feel free to reopen the PR when you have the time in the future

@Dylan-DPC Dylan-DPC closed this Feb 19, 2022
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uniquely identify CGU's and accurately track their size and merges
7 participants