-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deref_into_dyn_supertrait
lint.
#89461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 2, 2021
crlf0710
force-pushed
the
dyn_upcasting_lint
branch
from
October 2, 2021 11:27
b764994
to
ff2d735
Compare
This comment has been minimized.
This comment has been minimized.
notriddle
reviewed
Oct 2, 2021
compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs
Outdated
Show resolved
Hide resolved
crlf0710
force-pushed
the
dyn_upcasting_lint
branch
from
October 3, 2021 04:28
ff2d735
to
3b117b3
Compare
crlf0710
added
A-lint
Area: Lints (warnings about flaws in source code) such as unused_mut.
F-trait_upcasting
`#![feature(trait_upcasting)]`
labels
Oct 3, 2021
crlf0710
force-pushed
the
dyn_upcasting_lint
branch
from
October 3, 2021 04:36
3b117b3
to
250d126
Compare
nikomatsakis
reviewed
Oct 4, 2021
@bors r+ |
📌 Commit 250d126 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 6, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 7, 2021
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#89298 (Issue 89193 - Fix ICE when using `usize` and `isize` with SIMD gathers ) - rust-lang#89461 (Add `deref_into_dyn_supertrait` lint.) - rust-lang#89477 (Move items related to computing diffs to a separate file) - rust-lang#89559 (RustWrapper: adapt for LLVM API change) - rust-lang#89585 (Emit item no type error even if type inference fails) - rust-lang#89596 (Make cfg imply doc(cfg)) - rust-lang#89615 (Add InferCtxt::with_opaque_type_inference to get_body_with_borrowck_facts) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
pnkfelix
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
and removed
beta-nominated
Nominated for backporting to the compiler in the beta channel.
labels
Nov 16, 2021
(This is already in the 1.57-beta, according to discussion on #89190. So I'll just stable-nominate it.) |
pnkfelix
added
the
stable-nominated
Nominated for backporting to the compiler in the stable channel.
label
Nov 16, 2021
apiraino
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Nov 18, 2021
rustbot
removed
the
stable-nominated
Nominated for backporting to the compiler in the stable channel.
label
Nov 18, 2021
Tamschi
added a commit
to Tamschi/fruit-salad
that referenced
this pull request
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-lint
Area: Lints (warnings about flaws in source code) such as unused_mut.
F-trait_upcasting
`#![feature(trait_upcasting)]`
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of #89460. Resolves #89190.
Maybe also worth a beta backport if necessary.
r? @nikomatsakis