Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use projection cache or candidate cache in intercrate mode #89125

Merged
merged 1 commit into from
Sep 21, 2021

Commits on Sep 20, 2021

  1. Don't use projection cache or candidate cache in intercrate mode

    Fixes rust-lang#88969
    
    It appears that *just* disabling the evaluation cache (in rust-lang#88994)
    leads to other issues involving intercrate mode caching. I suspect
    that since we now always end up performing the full evaluation
    in intercrate mode, we end up 'polluting' the candidate and projection
    caches with results that depend on being in intercrate mode in some way.
    Previously, we might have hit a cached evaluation (stored during
    non-intercrate mode), and skipped doing this extra work in
    intercrate mode.
    
    The whole situation with intercrate mode caching is turning into
    a mess. Ideally, we would remove intercrate mode entirely - however,
    this might require waiting on Chalk.
    Aaron1011 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    6dbb9d4 View commit details
    Browse the repository at this point in the history