Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenize emoji as if they were valid identifiers #88781

Merged
merged 11 commits into from
Nov 25, 2021
Merged

Tokenize emoji as if they were valid identifiers #88781

merged 11 commits into from
Nov 25, 2021

Commits on Nov 23, 2021

  1. Tokenize emoji as if they were valid indentifiers 

    In the lexer, consider emojis to be valid identifiers and reject
them later to avoid knock down parse errors.
    @estebank
    estebank committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    5a68abb View commit details
    Browse the repository at this point in the history

  2. Replace ZWJ with nothing in terminal output

    @estebank
    estebank committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    a96fe02 View commit details
    Browse the repository at this point in the history

  3. Fix RustDoc

    @estebank
    estebank committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    20b69e6 View commit details
    Browse the repository at this point in the history

  4. Add unic-emoji-char and its dependencies to the allow list

    @estebank
    estebank committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    081198a View commit details
    Browse the repository at this point in the history

  5. fix fmt

    @estebank
    estebank committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    4489aeb View commit details
    Browse the repository at this point in the history

  6. Account for confusable codepoints when recovering emoji identifiers

    @estebank
    estebank committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    21224e6 View commit details
    Browse the repository at this point in the history

  7. review comment: plural of emoji is emoji

    @estebank
    estebank committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    d68add9 View commit details
    Browse the repository at this point in the history

  8. replace_tabs -> normalize_whitespace

    @estebank
    estebank committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    143f784 View commit details
    Browse the repository at this point in the history

  9. udpate comment to be more accurate

    @estebank
    estebank committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    38979a3 View commit details
    Browse the repository at this point in the history

  10. Sort FxHashSet's contents before emitting errors for consistent output

    @estebank
    estebank committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    5402e48 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Update cargo to fix tokenizer test affected by tokenizing emoji

    @estebank
    estebank committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    d929164 View commit details
    Browse the repository at this point in the history