Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #88556

Merged
merged 21 commits into from
Sep 1, 2021
Merged

Rollup of 9 pull requests #88556

merged 21 commits into from
Sep 1, 2021

Commits on Aug 15, 2021

  1. Configuration menu
    Copy the full SHA
    21f07b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Configuration menu
    Copy the full SHA
    f33f266 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Configuration menu
    Copy the full SHA
    5802f60 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. emit specific warning to clarify that foreign items can't have no_mangle

    remove extra commented code
    Deduplicate some diagnostics code
    add code symbols, machine applicable suggestion
    clarify error message
    asquared31415 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    fc125a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Configuration menu
    Copy the full SHA
    026322c View commit details
    Browse the repository at this point in the history
  2. Update E0785.md

    notriddle authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    435cdd0 View commit details
    Browse the repository at this point in the history
  3. Change wording to less jaron-y "non-auto trait"

    Co-authored-by: Vadim Petrochenkov <[email protected]>
    notriddle and petrochenkov committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    6e70678 View commit details
    Browse the repository at this point in the history
  4. Remove bolding on associated constants

    Associated types don't get bolded, so it looks off to have one kind
    bolded and one not.
    camelid committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    87e39ac View commit details
    Browse the repository at this point in the history
  5. Use the return value of readdir_r() instead of errno

    POSIX says:
    
    > If successful, the readdir_r() function shall return zero; otherwise,
    > an error number shall be returned to indicate the error.
    
    But we were previously using errno instead of the return value.  This
    led to issue rust-lang#86649.
    tavianator committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    0e0c8ae View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    753dac1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    06dd4c0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    227e004 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Rollup merge of rust-lang#86376 - asquared31415:extern-no-mangle-8420…

    …4, r=Mark-Simulacrum
    
    Emit specific warning to clarify that `#[no_mangle]` should not be applied on foreign statics or functions
    
    Foreign statics and foreign functions should not have `#[no_mangle]` applied, as it does nothing to the name and has some extra hidden behavior that is normally unwanted.  There was an existing warning for this, but it says the attribute is only allowed on "statics or functions", which to the user can be confusing.
    
    This PR adds a specific version of the unused `#[no_mangle]` warning that explains that the target is a *foreign* static or function and that they do not need the attribute.
    
    Fixes rust-lang#78989
    m-ou-se authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    dcefd68 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#88040 - nbdd0121:btreemap, r=m-ou-se

    BTree: remove Ord bound from new
    
    `K: Ord` bound is unnecessary on `BTree{Map,Set}::new` and their `Default` impl. No elements exist so there are nothing to compare anyway, so I don't think "future proof" would be a blocker here. This is analogous to `HashMap::new` not having a `K: Eq + Hash` bound.
    
    rust-lang#79245 originally does this and for some reason drops the change to `new` and `Default`. I can see why changes to other methods like `entry` or `symmetric_difference` need to be careful but I couldn't find out any reason not to do it on `new`.
    
    Removing the bound also makes the stabilisation of `const fn new` not depending on const trait bounds.
    
    cc `@steffahn` who suggests me to make this PR.
    
    r? `@dtolnay`
    m-ou-se authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    5878780 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#88053 - bjorn3:fix_flock_fallback_impl, r=c…

    …jgillot
    
    Fix the flock fallback implementation
    m-ou-se authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    8fd53e3 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#88350 - programmerjake:add-ppc-cr-xer-clobb…

    …ers, r=Amanieu
    
    add support for clobbering xer, cr, and cr[0-7] for asm! on OpenPower/PowerPC
    
    Fixes rust-lang#88315
    m-ou-se authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    494c563 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#88410 - camelid:fix-assoc-bold, r=Guillaume…

    …Gomez
    
    Remove bolding on associated constants
    
    Associated types don't get bolded, so it looks off to have one kind
    bolded and one not.
    m-ou-se authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    75b2ae5 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#88525 - notriddle:notriddle/coherence-dyn-a…

    …uto-trait, r=petrochenkov
    
    fix(rustc_typeck): produce better errors for dyn auto trait
    
    Fixes rust-lang#85026
    m-ou-se authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    bbc94ed View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#88542 - tavianator:readdir_r-errno, r=jyn514

    Use the return value of readdir_r() instead of errno
    
    POSIX says:
    
    > If successful, the readdir_r() function shall return zero; otherwise,
    > an error number shall be returned to indicate the error.
    
    But we were previously using errno instead of the return value.  This
    led to issue rust-lang#86649.
    m-ou-se authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    59588a9 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#88548 - inquisitivecrystal:intersperse, r=m…

    …-ou-se
    
    Stabilize `Iterator::intersperse()`
    
    This PR stabilizes the methods `Iterator::intersperse()` and `Iterator::intersperse_with()`. The FCP has [already completed](rust-lang#79524 (comment)).
    
    Closes rust-lang#79524.
    m-ou-se authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f436b6d View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#88551 - inquisitivecrystal:unsafe_cell_raw_…

    …get, r=m-ou-se
    
    Stabilize `UnsafeCell::raw_get()`
    
    This PR stabilizes the associated function `UnsafeCell::raw_get()`. The FCP has [already completed](rust-lang#66358 (comment)). While there was some discussion about the naming after the close of the FCP, it looks like people have agreed on this name. Still, it would probably be best if a `libs-api` member had a look at this and stated whether more discussion is needed.
    
    While I was at it, I added some tests for `UnsafeCell`, because there were barely any.
    
    Closes rust-lang#66358.
    m-ou-se authored Sep 1, 2021
    Configuration menu
    Copy the full SHA
    d313529 View commit details
    Browse the repository at this point in the history