-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest importing the right kind of macro. #88229
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// compile-flags: -Z deduplicate-diagnostics=yes | ||
// edition:2018 | ||
|
||
mod hey { | ||
pub use Copy as Bla; | ||
pub use std::println as bla; | ||
} | ||
|
||
#[derive(Bla)] | ||
//~^ ERROR cannot find derive macro `Bla` | ||
//~| NOTE consider importing this derive macro | ||
struct A; | ||
|
||
#[derive(println)] | ||
//~^ ERROR cannot find derive macro `println` | ||
struct B; | ||
|
||
fn main() { | ||
bla!(); | ||
//~^ ERROR cannot find macro `bla` | ||
//~| NOTE consider importing this macro | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
error: cannot find macro `bla` in this scope | ||
--> $DIR/issue-88228.rs:19:5 | ||
| | ||
LL | bla!(); | ||
| ^^^ | ||
| | ||
= note: consider importing this macro: | ||
crate::hey::bla | ||
|
||
error: cannot find derive macro `println` in this scope | ||
--> $DIR/issue-88228.rs:14:10 | ||
| | ||
LL | #[derive(println)] | ||
| ^^^^^^^ | ||
|
||
error: cannot find derive macro `Bla` in this scope | ||
--> $DIR/issue-88228.rs:9:10 | ||
| | ||
LL | #[derive(Bla)] | ||
| ^^^ | ||
| | ||
= note: consider importing this derive macro: | ||
crate::hey::Bla | ||
|
||
error: aborting due to 3 previous errors | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gonna have a merge conflict with the other PR, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That other PR includes this one as the first commit (with identical hash even), so should be fine. ^^