Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: show count of item contents when hidden #87024

Merged
merged 2 commits into from
Jul 21, 2021
Merged

rustdoc: show count of item contents when hidden #87024

merged 2 commits into from
Jul 21, 2021

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Jul 10, 2021 •
edited
Loading

Resolves #85494

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2021
@weihanglo weihanglo changed the title rustdoc: show count of items when hidden rustdoc: show count of item contents when hidden Jul 10, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@weihanglo weihanglo marked this pull request as draft July 11, 2021 01:54
@weihanglo weihanglo marked this pull request as ready for review July 11, 2021 02:43
@weihanglo
Copy link
Member Author

cc @Manishearth since you're the original author of #83337 😎

@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Contributor

bors commented Jul 21, 2021

📌 Commit 2b518ac has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2021
@ehuss ehuss mentioned this pull request Jul 21, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2021
@bors
Auto merge of rust-lang#87351 - ehuss:rollup-pga85az, r=ehuss
32c9b7b 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#81864 (docs: GlobalAlloc: completely replace example with one that works)
 - rust-lang#87024 (rustdoc: show count of item contents when hidden)
 - rust-lang#87278 (:arrow_up: rust-analyzer)
 - rust-lang#87326 (Update cargo)
 - rust-lang#87346 (Rename force-warns to force-warn)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7a19fba into rust-lang:master Jul 21, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 21, 2021
@weihanglo weihanglo deleted the issue-85494 branch July 22, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CraftSpider CraftSpider

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

rustdoc: when hiding item contents, include a count
7 participants
@weihanglo @rust-highfive @rust-log-analyzer @Manishearth @bors @CraftSpider @rustbot