-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use existing declaration of rust_eh_personality #86950
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
r? @nagisa |
I think #86801 would fix the same problem. It changes the |
That seems orthogonal. The issue fixed here is mismatch between signature of |
I see. It should probably still use the function signature for the real personality function on the respective platform though. |
If crate declares `rust_eh_personality`, re-use existing declaration as otherwise attempts to set function attributes that follow the declaration will fail (unless it happens to have exactly the same type signature as the one predefined in the compiler).
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit f612ba1 with merge 61e9a1afab2ee0f5eb2cbb91e7891fe24dada483... |
☀️ Try build successful - checks-actions |
Queued 61e9a1afab2ee0f5eb2cbb91e7891fe24dada483 with parent 64d171b, future comparison URL. |
Finished benchmarking try commit (61e9a1afab2ee0f5eb2cbb91e7891fe24dada483): comparison url. Summary: This benchmark run did not return any significant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. @bors rollup=never |
@bors r+ |
📌 Commit f612ba1 has been approved by |
⌛ Testing commit f612ba1 with merge 59ff8133eca6bb58f34079d16e656688afab930d... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Failure in |
@bors retry perhaps? |
☀️ Test successful - checks-actions |
If crate declares
rust_eh_personality
, re-use existing declarationas otherwise attempts to set function attributes that follow the
declaration will fail (unless it happens to have exactly the same
type signature as the one predefined in the compiler).
Fixes #70117.
Fixes #81469 (comment); probably.