-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cross-crate usage of feature(const_trait_impl)
#86750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this properly encodes cross-crate constness data.
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 30, 2021
Nice! @bors r+ |
📌 Commit c424510 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 30, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#85504 (the foundation owns rust trademarks) - rust-lang#85520 (Fix typo and improve documentation for E0632) - rust-lang#86680 (Improve error for missing -Z with debugging option) - rust-lang#86728 (Check node kind to avoid ICE in `check_expr_return()`) - rust-lang#86740 (copy rust-lld as ld in dist) - rust-lang#86746 (Fix rustdoc query type filter) - rust-lang#86750 (Test cross-crate usage of `feature(const_trait_impl)`) - rust-lang#86755 (alloc: `RawVec<T, A>::shrink` can be in `no_global_oom_handling`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Jul 2, 2021
ICE: evaluation of constant value failed | #[inline] causes compiler panic when bench-marking
#83937
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
See #67792 for the tracking issue, cc @oli-obk