Fix rust.css fonts. #86503
Fix rust.css fonts. #86503
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Is there any reason not to make the change here? |
jyn514
added
the
A-docs
|
I'm not sure exactly what you mean, can you say more about what you are thinking? How to fix this hasn't been decided, and would likely be a large amount of work (should error_index_generator be built into rustdoc? use mdbook? use something else?). And all the other pages would need to be adapted to something else as well (probably just drop the use of custom fonts, those pages are rarely seen). Alternatively, it could just drop the use of custom fonts altogether, but again that's a bit more work to bikeshed exactly what to use, and deal with the fallout from that (rendering issues, font size changes, etc.). |
|
I think I was confused, I was under the impression rust.css and rustdoc.css were basically the same and we could just plug in rustdoc.css wherever rust.css is used. If that's not the case I agree this makes sense to land first. |
|
Ah, yea, that is also an option. |
|
Yes that's what I said on zulip: for whatever reasons we decided to split both but since then, |
|
@GuillaumeGomez I think we should merge this for now and we can always do a more broad fix later |
|
📌 Commit 008d4d6 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 9 pull requests Successful merges: - rust-lang#86192 (Make OR_PATTERNS_BACK_COMPAT be a 2021 future-incompatible lint) - rust-lang#86248 (Add a regression test for issue-85113) - rust-lang#86274 (Spaces) - rust-lang#86349 (Add regression test for issue rust-lang#78632) - rust-lang#86424 (rustfmt: load nested out-of-line mods correctly) - rust-lang#86472 (Fix CI to fetch master on beta channel) - rust-lang#86473 (Rustdoc: Account for const-unstable functions) - rust-lang#86495 (Improve `proc_macro::{Punct, Spacing}` documentation) - rust-lang#86503 (Fix rust.css fonts.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The
rust.cssfile (used for all non-rustdoc and non-mdbook pages) has gotten out of sync with rustdoc's css. The two share the same fonts, so this updates them to match what rustdoc uses.It would be ideal not to need this at all, but that's for another time.