Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify early compilation interface #86489

Merged
merged 8 commits into from
Jul 1, 2021
Merged

Simplify early compilation interface #86489

merged 8 commits into from
Jul 1, 2021

Conversation

cjgillot
Copy link
Contributor

  • separate resolver creation and AST configuration.
  • bundle lowering with global_ctxt creation.

@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2021
@petrochenkov petrochenkov self-assigned this Jun 20, 2021
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 20, 2021
@bors
Copy link
Contributor

bors commented Jun 20, 2021

⌛ Trying commit cc326346b3ec0657b164407f5bf89f8ee2a43e96 with merge 4559bbd8a4a11c3b934fc8dcde6319d259f6396b...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 20, 2021

☀️ Try build successful - checks-actions
Build commit: 4559bbd8a4a11c3b934fc8dcde6319d259f6396b (4559bbd8a4a11c3b934fc8dcde6319d259f6396b)

@rust-timer
Copy link
Collaborator

Queued 4559bbd8a4a11c3b934fc8dcde6319d259f6396b with parent 75d1500, future comparison URL.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2021
@jackh726 jackh726 removed their assignment Jun 20, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (4559bbd8a4a11c3b934fc8dcde6319d259f6396b): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 20, 2021
@petrochenkov petrochenkov removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 20, 2021
@jyn514 jyn514 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 20, 2021
jyn514
jyn514 reviewed Jun 20, 2021
View reviewed changes
src/librustdoc/doctest.rs Outdated Show resolved Hide resolved
@bors

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed Jun 29, 2021
View reviewed changes
compiler/rustc_interface/src/passes.rs Outdated Show resolved Hide resolved
compiler/rustc_interface/src/passes.rs Outdated Show resolved Hide resolved
compiler/rustc_interface/src/passes.rs Outdated Show resolved Hide resolved
compiler/rustc_interface/src/queries.rs
@@ -83,7 +82,6 @@ pub struct Queries<'tcx> {
register_plugins: Query<(ast::Crate, Lrc<LintStore>)>,
expansion: Query<(ast::Crate, Steal<Rc<RefCell<BoxedResolver>>>, Lrc<LintStore>)>,
dep_graph: Query<DepGraph>,
lower_to_hir: Query<(&'tcx Crate<'tcx>, Steal<ResolverOutputs>)>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps Zoxc had something in mind when making lower_to_hir individually available, but if no tools use it right now, then it seems fine to remove.

compiler/rustc_interface/src/passes.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2021
@cjgillot cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2021

📌 Commit f698774 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2021
@bors
Copy link
Contributor

bors commented Jun 30, 2021

⌛ Testing commit f698774 with merge e6f450b...

@bors
Copy link
Contributor

bors commented Jul 1, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing e6f450b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 1, 2021
@bors bors merged commit e6f450b into rust-lang:master Jul 1, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 1, 2021
This was referenced Jul 1, 2021
Merged
Merged
@cjgillot cjgillot deleted the lower branch July 1, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
9 participants
@cjgillot @rust-highfive @rust-timer @bors @rust-log-analyzer @petrochenkov @jyn514 @jackh726 @rustbot