Remove dead toggle JS code #85548
Merged
Remove dead toggle JS code #85548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
C-cleanup
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit aee054d has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 21, 2021
Remove dead toggle JS code Explanations on how I got there: I randomly saw `adjustToggle` while browsing through code, checked where it was called, put a `debugger;` instruction in it and checked on all pages while playing with settings and toggles. The breakpoint was never triggered. I then looked at `collapseNonInherent` (its grand-parent). In there, the breakpoint was triggered so I look at what was being done and in fact... nothing. So I simply removed it all, re-ran the tests and play with the UI. Everything is working as expected. Better double check in case I forgot to check a case though, but if nothing has been left out, then it's a great cleanup once again. :) r? `@jsha`
This was referenced May 21, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 21, 2021
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#85506 (Reset "focusedByTab" field when doing another search) - rust-lang#85548 (Remove dead toggle JS code) - rust-lang#85550 (facepalm: operator precedence fail on my part.) - rust-lang#85555 (Check for more things in THIR unsafeck) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanations on how I got there: I randomly saw
adjustTogglewhile browsing through code, checked where it was called, put adebugger;instruction in it and checked on all pages while playing with settings and toggles. The breakpoint was never triggered. I then looked atcollapseNonInherent(its grand-parent). In there, the breakpoint was triggered so I look at what was being done and in fact... nothing. So I simply removed it all, re-ran the tests and play with the UI. Everything is working as expected.Better double check in case I forgot to check a case though, but if nothing has been left out, then it's a great cleanup once again. :)
r? @jsha