Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Prepare beta 1.53.0 #84909

Merged
merged 14 commits into from
May 6, 2021
Merged

[beta] Prepare beta 1.53.0 #84909

merged 14 commits into from
May 6, 2021

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented May 4, 2021 •
edited
Loading

Along with updating the channel and updating the bootstrap compiler, this also includes:

Changes we backported to 1.52.0 that we also need to include in 1.53.0 to avoid regressing:

r? @ghost

@pietroalbini pietroalbini marked this pull request as draft May 4, 2021 14:26
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pnkfelix @pietroalbini
Revert PR 81473 to resolve (on beta) issues 81626 and 81658.
bd9c30d 
Revert "Add missing brace"

This reverts commit 85ad773.

Revert "Simplify base_expr"

This reverts commit 899aae4.

Revert "Warn write-only fields"

This reverts commit d3c69a4.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 4, 2021
@camelid
Copy link
Member

camelid commented May 5, 2021

Just checking, is it intentional that this is filed against master rather than beta? According to src/version, master is currently 1.54.0 (not 1.53.0).

@jyn514 jyn514 mentioned this pull request May 5, 2021
Closed
@pietroalbini pietroalbini changed the base branch from master to beta May 5, 2021 07:58
@pietroalbini
Copy link
Member Author

Ugh thanks for pointing that out @camelid, we definitely need CI to prevent that from happening :(

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pietroalbini pietroalbini mentioned this pull request May 5, 2021
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@pietroalbini
Revert PR 83866
bbfdfa9 
That PR caused multiple test failures when Rust's channel is changed
from nightly to anything else. The commit will have to be landed again
after the test suite is fixed.
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 5, 2021
@bors
Copy link
Contributor

bors commented May 5, 2021

⌛ Testing commit 3a1e414 with merge db7d6545ccda8d355958783fd0852d3161bb6db6...

@jyn514 jyn514 mentioned this pull request May 5, 2021
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 5, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 5, 2021
@pietroalbini
Copy link
Member Author

@bors r=Mark-Simulacrum p=100

@bors
Copy link
Contributor

bors commented May 5, 2021

📌 Commit 4894656 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2021
@bors
Copy link
Contributor

bors commented May 5, 2021

⌛ Testing commit 4894656 with merge 65c2ab300af906f9a5eb543750cae3c34885035e...

@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented May 5, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 5, 2021
@pietroalbini
Copy link
Member Author

@bors retry spurious network

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2021
@bors
Copy link
Contributor

bors commented May 5, 2021

⌛ Testing commit 4894656 with merge e58c811...

@bors
Copy link
Contributor

bors commented May 6, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing e58c811 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 6, 2021
@bors bors merged commit e58c811 into rust-lang:beta May 6, 2021
@rustbot rustbot added this to the 1.53.0 milestone May 6, 2021
@pietroalbini pietroalbini deleted the beta-next branch May 6, 2021 07:47
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 6, 2021
@Dylan-DPC
Rollup merge of rust-lang#84950 - pietroalbini:revert-3478f83c0, r=Ma…
ab65989 
…rk-Simulacrum

Revert PR 83866

rust-lang#83866 caused multiple test failures when Rust's channel is changed from nightly to anything else. The PR will have to be landed again after the test suite is fixed.

The two kinds of test failures were:

* Rustdoc tests failed because the links in the generated HTML didn't point at nightly anymore, see rust-lang#84909 (comment)
* Rustdoc UI tests failed because the links included in error messages didn't point at nightly anymore, see rust-lang#84909 (comment)

r? `@Mark-Simulacrum`
cc `@jyn514`
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 6, 2021
@Dylan-DPC
Rollup merge of rust-lang#84950 - pietroalbini:revert-3478f83c0, r=Ma…
ccc820e 
…rk-Simulacrum

Revert PR 83866

rust-lang#83866 caused multiple test failures when Rust's channel is changed from nightly to anything else. The PR will have to be landed again after the test suite is fixed.

The two kinds of test failures were:

* Rustdoc tests failed because the links in the generated HTML didn't point at nightly anymore, see rust-lang#84909 (comment)
* Rustdoc UI tests failed because the links included in error messages didn't point at nightly anymore, see rust-lang#84909 (comment)

r? ``@Mark-Simulacrum``
cc ``@jyn514``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.