Update clang to 12.0.0 on Windows and macOS #84894
Conversation
Currently, we have LLVM tarballs for win64, generated by someone running the installer via wine and tarring up the result. 7z knows how to extract NSIS installers directly, and the result is identical to our tarball, except that it doesn't include `Uninstall.exe` (which we don't care about) and it includes the NSIS plugin directory (which we also don't care about). This simplifies the process of upgrading CI, and allows us to just mirror the upstream release .exe directly. This also improves our supply chain.
Needed for rust-lang#84764 . Tarballs already uploaded to the CI mirror bucket.
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
|
⌛ Trying commit b9ef51f with merge a8d0afd4be04441c537db76036b1e6bafb7cc6c8... |
|
☀️ Try build successful - checks-actions |
|
@bors r+ rollup=iffy |
|
📌 Commit b9ef51f has been approved by |
bors
added
S-waiting-on-bors
|
We should try to make sure that the build still works without this on Windows/macOS, though, as expecting really recent toolchains isn't great. My understanding is that we should only need this on aarch64 Windows, perhaps, so in that sense it shouldn't be too necessary for most people? |
|
This is needed when building an aarch64 target on a Windows host. It's only a requirement on Windows; other platforms can continue to use older compilers. It seems more reasonable to expect an up-to-date toolchain on Windows, since it would normally be installed directly rather than obtained from a distribution. And if people specifically need to build with an older compiler, they could potentially disable aarch64 target support. |
|
☀️ Test successful - checks-actions |
…acrum [beta] Backport rust-lang#84894 to fix beta CI Currently, beta backports fail with this failure: rust-lang#86036 (comment) ``` STL1000: Unexpected compiler version, expected Clang 11.0.0 or newer. ``` The previous beta backport was successful because it uses a Visual Studio tool v14.28.29910 but now CI uses v14.29.30037. rust-lang#84894 updated clang to 12 so master didn't catch this change, I guess. Hopefully, it fixes CI failures on beta.
Needed for #84764 . Tarballs
already uploaded to the CI mirror bucket.