New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse unnamed fields of struct and union type #84571

Merged

bors merged 4 commits into rust-lang:master from jedel1043:issue-49804-impl

May 17, 2021

Contributor

jedel1043 commented Apr 26, 2021

Added the unnamed_fields feature gate.

This is a prototype of RFC 2102, so any suggestions are greatly appreciated.

r? @petrochenkov

rust-highfive assigned petrochenkov

Collaborator

rust-highfive commented Apr 26, 2021

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rust-highfive added the S-waiting-on-review label

jedel1043 force-pushed the issue-49804-impl branch 2 times, most recently from 2478847 to 8abfff4 Compare

April 26, 2021 14:33

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

petrochenkov reviewed

View reviewed changes

compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved

compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved

compiler/rustc_ast/src/mut_visit.rs Outdated Show resolved Hide resolved

compiler/rustc_ast_pretty/src/pprust/state.rs Show resolved Hide resolved

compiler/rustc_hir/src/hir.rs Outdated Show resolved Hide resolved

compiler/rustc_parse/src/parser/item.rs Outdated Show resolved Hide resolved

compiler/rustc_ast_passes/src/ast_validation.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author and removed S-waiting-on-review labels

jedel1043 force-pushed the issue-49804-impl branch from d13ca6d to 0fe4584 Compare

May 3, 2021 21:26

This comment has been minimized.

Sign in to view

jedel1043 force-pushed the issue-49804-impl branch 2 times, most recently from 74e34d8 to 70b419c Compare

May 3, 2021 23:35

This comment has been minimized.

Sign in to view

jedel1043 force-pushed the issue-49804-impl branch from 70b419c to 31bbb8e Compare

May 9, 2021 23:03

This comment has been minimized.

Sign in to view

jedel1043 force-pushed the issue-49804-impl branch from 31bbb8e to 675ddfc Compare

May 10, 2021 13:31

jedel1043 marked this pull request as ready for review

May 10, 2021 13:31

jedel1043 requested a review from petrochenkov

May 10, 2021 13:44

petrochenkov added S-waiting-on-review and removed S-waiting-on-author labels

This comment has been minimized.

Sign in to view

petrochenkov reviewed

View reviewed changes

compiler/rustc_hir_pretty/src/lib.rs Outdated Show resolved Hide resolved

compiler/rustc_ast_lowering/src/lib.rs Outdated Show resolved Hide resolved

compiler/rustc_ast_passes/src/ast_validation.rs Outdated Show resolved Hide resolved

compiler/rustc_ast_passes/src/ast_validation.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author and removed S-waiting-on-review labels

jedel1043 force-pushed the issue-49804-impl branch from 675ddfc to 36a9486 Compare

May 11, 2021 18:55

petrochenkov added S-waiting-on-review and removed S-waiting-on-author labels

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors and removed S-waiting-on-review labels

Contributor

bors commented May 17, 2021

⌛ Testing commit 64acb7d with merge 9964284...

Contributor

bors commented May 17, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 9964284 to master...

bors added the merged-by-bors label

bors merged commit 9964284 into rust-lang:master

rustbot added this to the 1.54.0 milestone

jedel1043 deleted the issue-49804-impl branch

May 17, 2021 14:54

bors mentioned this pull request

Add hir::GenericArg::Infer #83484

Merged

calebcartwright mentioned this pull request

bump deps rust-lang/rls#1737

Merged

Member

calebcartwright commented May 24, 2021

For future reference please ping me on any and all changes to the rustfmt subtree. The highfive bot is supposed to be configured to do the same but failed to do so here. Now that rustfmt is a subtree and folks are able to modify the rustfmt source here it's really important that the rustfmt team is in the loop on any changes to the rustfmt source to avoid breaking our formatting guarantees for nightly users

Contributor Author

jedel1043 commented May 24, 2021 •

edited

Loading

@calebcartwright Noted. Also, should I open an issue on rust-lang/high-five?

calebcartwright mentioned this pull request

Mention notifications for changes to subtrees rust-lang/highfive#337

Closed

Member

calebcartwright commented May 24, 2021

No worries and thanks @jedel1043. The subtree change is still relatively new and there's unsurprisingly a few kinks to work out.

I've no idea what's up with the lack of bot notifications and am already trying to run that down, so thanks for the offer but no need for you to open an issue.

Xanewok mentioned this pull request

Allow formatting Anonymous{Struct, Union} declarations rust-lang/rustfmt#4851

Merged

dtolnay mentioned this pull request

Type called union wreaks havoc since 1.54 #88583

Closed

pnkfelix mentioned this pull request

Revert anon union parsing #88775

Merged

Manishearth added a commit to Manishearth/rust that referenced this pull request


          Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…

b385de7

… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request


          Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…

a5f470b

… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.

Manishearth added a commit to Manishearth/rust that referenced this pull request


          Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…

c09e12b

… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.

Manishearth added a commit to Manishearth/rust that referenced this pull request


          Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…

ca0c556

… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.

Manishearth added a commit to Manishearth/rust that referenced this pull request


          Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…

8417ac5

… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.

Manishearth added a commit to Manishearth/rust that referenced this pull request


          Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…

a8a4504

… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.

Manishearth added a commit to Manishearth/rust that referenced this pull request


          Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…

75fae88

… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.

Manishearth added a commit to Manishearth/rust that referenced this pull request


          Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…

95306c6

… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.

Manishearth added a commit to Manishearth/rust that referenced this pull request


          Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…

fb2d7df

… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.

dtolnay mentioned this pull request

Update test suite to nightly-2021-09-22 dtolnay/syn#1069

Merged

calebcartwright pushed a commit to calebcartwright/rust that referenced this pull request


          Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…

52e1a52

… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.

carbotaniuman mentioned this pull request

Parse unnamed struct and union fields #99754

Closed

petrochenkov mentioned this pull request

Parse unnamed fields and anonymous structs or unions #114782

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors S-waiting-on-bors