Add --run flag to compiletest #84500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
tmandry
force-pushed
the
compiletest-run-flag
branch
from
9321d6c
to
e1a6f1e
Compare
|
I guess you're intending to use this via --test-args --run or so? Does that work for you? If so, r=me, otherwise happy to re-review after the option is pulled through and exposed in rustbuild as a flag as well. |
Mark-Simulacrum
added
S-waiting-on-author
|
Yep, that's what I was going to do at least for now. I wasn't sure how many others would need it. @bors r=Mark-Simulacrum |
|
📌 Commit e1a6f1e2b7be1392dec80c21e243eb49f8e3842b has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- actually I'm seeing some problems with this |
bors
added
S-waiting-on-author
|
Okay, I fixed some things and threaded I've confirmed that I can run |
This comment has been minimized.
This comment has been minimized.
tmandry
added
S-waiting-on-review
This controls whether run-* tests actually get run.
tmandry
force-pushed
the
compiletest-run-flag
branch
from
a95baf2
to
938d509
Compare
I was wary of doing any automatic disabling here, since should-fail is how we test compiletest itself.
tmandry
force-pushed
the
compiletest-run-flag
branch
from
938d509
to
1e46b18
Compare
|
@bors r+ rollup Thanks! |
|
📌 Commit 1e46b18 has been approved by |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 6, 2021
…=Mark-Simulacrum Add `needs-unwind` and beginning of support for testing `panic=abort` std to compiletest For the Fuchsia platform we build libstd with `panic=abort` and would like a way to run tests with that enabled. This adds low-level support for this directly to compiletest. In the future I'd like to add high-level support in rustbuild, e.g. having target-specific flags that allow configuring a panic strategy. (Side note: It would be nice if we could also build multiple configurations for the same target, but I'm getting ahead of myself.) This plus rust-lang#84500 have everything that's needed to get ui tests passing on fuchsia targets. Part of rust-lang#84766. Note that this change only includes the header on tests which need an unwinder to _build_, not those which need it to _run_. r? `@Mark-Simulacrum`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 6, 2021
…k-Simulacrum Add --run flag to compiletest This controls whether run-* tests actually get run. r? `@Mark-Simulacrum`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 6, 2021
…=Mark-Simulacrum Add `needs-unwind` and beginning of support for testing `panic=abort` std to compiletest For the Fuchsia platform we build libstd with `panic=abort` and would like a way to run tests with that enabled. This adds low-level support for this directly to compiletest. In the future I'd like to add high-level support in rustbuild, e.g. having target-specific flags that allow configuring a panic strategy. (Side note: It would be nice if we could also build multiple configurations for the same target, but I'm getting ahead of myself.) This plus rust-lang#84500 have everything that's needed to get ui tests passing on fuchsia targets. Part of rust-lang#84766. Note that this change only includes the header on tests which need an unwinder to _build_, not those which need it to _run_. r? ``@Mark-Simulacrum``
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 6, 2021
…k-Simulacrum Add --run flag to compiletest This controls whether run-* tests actually get run. r? ``@Mark-Simulacrum``
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 6, 2021
…=Mark-Simulacrum Add `needs-unwind` and beginning of support for testing `panic=abort` std to compiletest For the Fuchsia platform we build libstd with `panic=abort` and would like a way to run tests with that enabled. This adds low-level support for this directly to compiletest. In the future I'd like to add high-level support in rustbuild, e.g. having target-specific flags that allow configuring a panic strategy. (Side note: It would be nice if we could also build multiple configurations for the same target, but I'm getting ahead of myself.) This plus rust-lang#84500 have everything that's needed to get ui tests passing on fuchsia targets. Part of rust-lang#84766. Note that this change only includes the header on tests which need an unwinder to _build_, not those which need it to _run_. r? ```@Mark-Simulacrum```
This was referenced May 6, 2021
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 6, 2021
…=Mark-Simulacrum Add `needs-unwind` and beginning of support for testing `panic=abort` std to compiletest For the Fuchsia platform we build libstd with `panic=abort` and would like a way to run tests with that enabled. This adds low-level support for this directly to compiletest. In the future I'd like to add high-level support in rustbuild, e.g. having target-specific flags that allow configuring a panic strategy. (Side note: It would be nice if we could also build multiple configurations for the same target, but I'm getting ahead of myself.) This plus rust-lang#84500 have everything that's needed to get ui tests passing on fuchsia targets. Part of rust-lang#84766. Note that this change only includes the header on tests which need an unwinder to _build_, not those which need it to _run_. r? ````@Mark-Simulacrum````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#84409 (Ensure TLS destructors run before thread joins in SGX) - rust-lang#84500 (Add --run flag to compiletest) - rust-lang#84728 (Add test for suggestion to borrow unsized function parameters) - rust-lang#84734 (Add `needs-unwind` and beginning of support for testing `panic=abort` std to compiletest) - rust-lang#84755 (Allow using `core::` in intra-doc links within core itself) - rust-lang#84871 (Disallows `#![feature(no_coverage)]` on stable and beta (using standard crate-level gating)) - rust-lang#84872 (Wire up tidy dependency checks for cg_clif) - rust-lang#84896 (Handle incorrect placement of parentheses in trait bounds more gracefully) - rust-lang#84905 (CTFE engine: rename copy → copy_intrinsic, move to intrinsics.rs) - rust-lang#84953 (Remove unneeded call to with_default_session_globals in rustdoc highlight) - rust-lang#84987 (small nits) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This controls whether run-* tests actually get run.
r? @Mark-Simulacrum