Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debuginfo for closures and async functions on Windows MSVC #83941

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Improve debuginfo for closures and async functions on Windows MSVC #83941

merged 1 commit into from
Apr 9, 2021

Commits on Apr 8, 2021

  1. Fix closed over variables not available in debuginfo for Windows MSVC 

    The issue was that the resulting debuginfo was too complex for LLVM to
translate into CodeView records correctly. As a result, it simply
ignored the debuginfo which meant Windows debuggers could not display
any closed over variables when stepping inside a closure.

This fixes that by spilling additional variables to the stack so that
the resulting debuginfo is simple (just `*my_variable.dbg.spill`) and
LLVM can generate the correct CV records.
    @wesleywiser
    wesleywiser committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    533002d View commit details
    Browse the repository at this point in the history