Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow the use of high byte registes as operands on x86_64 #83853

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Apr 4, 2021

They are still allowed on x86 though.

Fixes #83495

r? @nagisa

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2021
@nagisa
Copy link
Member

nagisa commented Apr 4, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Apr 4, 2021

📌 Commit ba65f37 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 5, 2021
Disallow the use of high byte registes as operands on x86_64

They are still allowed on x86 though.

Fixes rust-lang#83495

r? ``@nagisa``
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 5, 2021
Disallow the use of high byte registes as operands on x86_64

They are still allowed on x86 though.

Fixes rust-lang#83495

r? `@nagisa`
@jyn514
Copy link
Member

jyn514 commented Apr 5, 2021

Failed in rollup: #83873 (comment)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 5, 2021
@Amanieu
Copy link
Member Author

Amanieu commented Apr 5, 2021

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Apr 5, 2021

📌 Commit b1bcff0 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 5, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2021
Rollup of 5 pull requests

Successful merges:

 - rust-lang#83368 (Add `download-rustc = "if-unchanged"`)
 - rust-lang#83705 (Give a better error when --theme is not a CSS file)
 - rust-lang#83853 (Disallow the use of high byte registes as operands on x86_64)
 - rust-lang#83877 (Remove unnecessary exceptions to the platform-specific code check)
 - rust-lang#83878 (Fix racing file access in tidy)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 49b178e into rust-lang:master Apr 5, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM Error with asm!
6 participants