Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for unassigned query provider #83367

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Improve error message for unassigned query provider #83367

merged 1 commit into from
Mar 22, 2021

Conversation

richkadel
Copy link
Contributor

Fixes: #83122

r? @jyn514

This implements the change we agreed on. Thanks!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2021
@jyn514 jyn514 added A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 22, 2021
@jyn514
Copy link
Member

jyn514 commented Mar 22, 2021

Thanks! r=me with CI passing (please use r=jyn514, not r+).

@bors delegate=richkadel

@bors
Copy link
Contributor

bors commented Mar 22, 2021

✌️ @richkadel can now approve this pull request

@richkadel
Copy link
Contributor Author

@bors r=jyn514 rollup

@bors
Copy link
Contributor

bors commented Mar 22, 2021

📌 Commit 688c857 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2021
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 22, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2021
@bors
Auto merge of rust-lang#83376 - Dylan-DPC:rollup-s2fsjwj, r=Dylan-DPC
2287a88 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#82374 (Add license metadata for std dependencies)
 - rust-lang#82683 (Document panicking cases for integer division and remainder)
 - rust-lang#83272 (Clarify non-exact length in the Iterator::take documentation)
 - rust-lang#83338 (Fix test for rust-lang#82270)
 - rust-lang#83351 (post-drop-elab check-const: explain why we still check qualifs)
 - rust-lang#83367 (Improve error message for unassigned query provider)
 - rust-lang#83372 (SplitInclusive is public API)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 014a4ee into rust-lang:master Mar 22, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 22, 2021
@jyn514 jyn514 mentioned this pull request Sep 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

Missing tcx query provider is hard to diagnose - error message is not intuitive
5 participants
@richkadel @jyn514 @bors @rust-highfive @rustbot