-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #82795
Rollup of 10 pull requests #82795
Commits on Jan 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f45bdcc - Browse repository at this point
Copy the full SHA f45bdccView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3e47d9 - Browse repository at this point
Copy the full SHA c3e47d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa76db3 - Browse repository at this point
Copy the full SHA fa76db3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11c49f6 - Browse repository at this point
Copy the full SHA 11c49f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 260a270 - Browse repository at this point
Copy the full SHA 260a270View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f60a30 - Browse repository at this point
Copy the full SHA 5f60a30View commit details -
Configuration menu - View commit details
-
Copy full SHA for eea99f4 - Browse repository at this point
Copy the full SHA eea99f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e56637 - Browse repository at this point
Copy the full SHA 7e56637View commit details -
Configuration menu - View commit details
-
Copy full SHA for 442de9a - Browse repository at this point
Copy the full SHA 442de9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1190321 - Browse repository at this point
Copy the full SHA 1190321View commit details -
Configuration menu - View commit details
-
Copy full SHA for 421b40c - Browse repository at this point
Copy the full SHA 421b40cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 265db94 - Browse repository at this point
Copy the full SHA 265db94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93870c8 - Browse repository at this point
Copy the full SHA 93870c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7869371 - Browse repository at this point
Copy the full SHA 7869371View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8e0f8a - Browse repository at this point
Copy the full SHA c8e0f8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96255f8 - Browse repository at this point
Copy the full SHA 96255f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 389e638 - Browse repository at this point
Copy the full SHA 389e638View commit details -
Configuration menu - View commit details
-
Copy full SHA for b837f3a - Browse repository at this point
Copy the full SHA b837f3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81aba38 - Browse repository at this point
Copy the full SHA 81aba38View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc9cd4a - Browse repository at this point
Copy the full SHA fc9cd4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7674ae1 - Browse repository at this point
Copy the full SHA 7674ae1View commit details
Commits on Feb 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7b021aa - Browse repository at this point
Copy the full SHA 7b021aaView commit details
Commits on Feb 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a3db47a - Browse repository at this point
Copy the full SHA a3db47aView commit details
Commits on Mar 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 040735c - Browse repository at this point
Copy the full SHA 040735cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f49ed7a - Browse repository at this point
Copy the full SHA f49ed7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6d926d - Browse repository at this point
Copy the full SHA a6d926dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 618c395 - Browse repository at this point
Copy the full SHA 618c395View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a86184 - Browse repository at this point
Copy the full SHA 3a86184View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee65416 - Browse repository at this point
Copy the full SHA ee65416View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3b49c2 - Browse repository at this point
Copy the full SHA d3b49c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5ff54c - Browse repository at this point
Copy the full SHA c5ff54cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 217c886 - Browse repository at this point
Copy the full SHA 217c886View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16c4afb - Browse repository at this point
Copy the full SHA 16c4afbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95e330b - Browse repository at this point
Copy the full SHA 95e330bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 316e9db - Browse repository at this point
Copy the full SHA 316e9dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49f32e0 - Browse repository at this point
Copy the full SHA 49f32e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e48670c - Browse repository at this point
Copy the full SHA e48670cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 055db16 - Browse repository at this point
Copy the full SHA 055db16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4be7052 - Browse repository at this point
Copy the full SHA 4be7052View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bf6652 - Browse repository at this point
Copy the full SHA 6bf6652View commit details -
Configuration menu - View commit details
-
Copy full SHA for da3995f - Browse repository at this point
Copy the full SHA da3995fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1999a31 - Browse repository at this point
Copy the full SHA 1999a31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25637b2 - Browse repository at this point
Copy the full SHA 25637b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9425e30 - Browse repository at this point
Copy the full SHA 9425e30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66a2606 - Browse repository at this point
Copy the full SHA 66a2606View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b9ac4d - Browse repository at this point
Copy the full SHA 8b9ac4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for aeb4ea7 - Browse repository at this point
Copy the full SHA aeb4ea7View commit details
Commits on Mar 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 09cbcdc - Browse repository at this point
Copy the full SHA 09cbcdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6fe24a - Browse repository at this point
Copy the full SHA f6fe24aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69d95e2 - Browse repository at this point
Copy the full SHA 69d95e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d85d82a - Browse repository at this point
Copy the full SHA d85d82aView commit details -
Configuration menu - View commit details
-
Copy full SHA for da01455 - Browse repository at this point
Copy the full SHA da01455View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aedb4c - Browse repository at this point
Copy the full SHA 1aedb4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for eddd4f0 - Browse repository at this point
Copy the full SHA eddd4f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb18746 - Browse repository at this point
Copy the full SHA eb18746View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfce60e - Browse repository at this point
Copy the full SHA cfce60eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a8e401 - Browse repository at this point
Copy the full SHA 0a8e401View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bd1204 - Browse repository at this point
Copy the full SHA 5bd1204View commit details -
Add diagnostic item to
Default
traitRequired to resolve rust-lang#6562 rust-clippy issue.
Configuration menu - View commit details
-
Copy full SHA for a5951d4 - Browse repository at this point
Copy the full SHA a5951d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58d6f80 - Browse repository at this point
Copy the full SHA 58d6f80View commit details -
Configuration menu - View commit details
-
Copy full SHA for f223aff - Browse repository at this point
Copy the full SHA f223affView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80fcdef - Browse repository at this point
Copy the full SHA 80fcdefView commit details
Commits on Mar 5, 2021
-
Remove unused code from main.js
It looks like `lev_distance` was used in a very old version of the function, since it was written but never read, and Blame reports that it was added before the `checkGenerics` function header itself. `convertHTMLToPlaintext` is was removed by 768d5e9
Configuration menu - View commit details
-
Copy full SHA for ad91915 - Browse repository at this point
Copy the full SHA ad91915View commit details -
Rollup merge of rust-lang#80723 - rylev:noop-lint-pass, r=estebank
Implement NOOP_METHOD_CALL lint Implements the beginnings of rust-lang/lang-team#67 - a lint for detecting noop method calls (e.g, calling `<&T as Clone>::clone()` when `T: !Clone`). This PR does not fully realize the vision and has a few limitations that need to be addressed either before merging or in subsequent PRs: * [ ] No UFCS support * [ ] The warning message is pretty plain * [ ] Doesn't work for `ToOwned` The implementation uses [`Instance::resolve`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/instance/struct.Instance.html#method.resolve) which is normally later in the compiler. It seems that there are some invariants that this function relies on that we try our best to respect. For instance, it expects substitutions to have happened, which haven't yet performed, but we check first for `needs_subst` to ensure we're dealing with a monomorphic type. Thank you to ```@davidtwco,``` ```@Aaron1011,``` and ```@wesleywiser``` for helping me at various points through out this PR ❤️.
Configuration menu - View commit details
-
Copy full SHA for e6a6df5 - Browse repository at this point
Copy the full SHA e6a6df5View commit details -
Rollup merge of rust-lang#80763 - petrochenkov:pubusecrate, r=estebank
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)). Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions. So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
Configuration menu - View commit details
-
Copy full SHA for ec2619c - Browse repository at this point
Copy the full SHA ec2619cView commit details -
Rollup merge of rust-lang#81136 - Xavientois:io_reader_size_hint, r=c…
…ramertj Improved IO Bytes Size Hint After trying to implement better `size_hint()` return values for `File` in [this PR](rust-lang#81044) and changing to implementing it for `BufReader` in [this PR](rust-lang#81052), I have arrived at this implementation that provides tighter bounds for the `Bytes` iterator of various readers including `BufReader`, `Empty`, and `Chain`. Unfortunately, for `BufReader`, the size_hint only improves after calling `fill_buffer` due to it using the contents of the buffer for the hint. Nevertheless, the the tighter bounds should result in better pre-allocation of space to handle the contents of the `Bytes` iterator. Closes rust-lang#81052
Configuration menu - View commit details
-
Copy full SHA for 6013811 - Browse repository at this point
Copy the full SHA 6013811View commit details -
Rollup merge of rust-lang#81939 - kper:fixing-81584-allocate-in-iter,…
… r=davidtwco Add suggestion `.collect()` for iterators in iterators Closes rust-lang#81584 ``` error[E0515]: cannot return value referencing function parameter `y` --> main3.rs:4:38 | 4 | ... .map(|y| y.iter().map(|x| x + 1)) | -^^^^^^^^^^^^^^^^^^^^^^ | | | returns a value referencing data owned by the current function | `y` is borrowed here | help: Maybe use `.collect()` to allocate the iterator ``` Added the suggestion: `help: Maybe use `.collect()` to allocate the iterator`
Configuration menu - View commit details
-
Copy full SHA for 20887b7 - Browse repository at this point
Copy the full SHA 20887b7View commit details -
Rollup merge of rust-lang#82289 - SkiFire13:fix-issue-82282, r=m-ou-se
Fix underflow in specialized ZipImpl::size_hint Fixes rust-lang#82282
Configuration menu - View commit details
-
Copy full SHA for ee796c6 - Browse repository at this point
Copy the full SHA ee796c6View commit details -
Rollup merge of rust-lang#82728 - calebsander:refactor/bufreader-buf,…
… r=m-ou-se Avoid unnecessary Vec construction in BufReader As mentioned in rust-lang#80460, creating a `Vec` and calling `Vec::into_boxed_slice()` emits unnecessary calls to `realloc()` and `free()`. Updated the code to use `Box::new_uninit_slice()` to create a boxed slice directly. I think this also makes it more explicit that the initial contents of the buffer are uninitialized. r? ``@m-ou-se``
Configuration menu - View commit details
-
Copy full SHA for 68f2934 - Browse repository at this point
Copy the full SHA 68f2934View commit details -
Rollup merge of rust-lang#82764 - m-ou-se:map-try-insert, r=Amanieu
Add {BTreeMap,HashMap}::try_insert `{BTreeMap,HashMap}::insert(key, new_val)` returns `Some(old_val)` if the key was already in the map. It's often useful to assert no duplicate values are inserted. We experimented with `map.insert(key, val).unwrap_none()` (rust-lang#62633), but decided that that's not the kind of method we'd like to have on `Option`s. `insert` always succeeds because it replaces the old value if it exists. One could argue that `insert()` is never the right method for panicking on duplicates, since already handles that case by replacing the value, only allowing you to panic after that already happened. This PR adds a `try_insert` method that instead returns a `Result::Err` when the key already exists. This error contains both the `OccupiedEntry` and the value that was supposed to be inserted. This means that unwrapping that result gives more context: ```rust map.insert(10, "world").unwrap_none(); // thread 'main' panicked at 'called `Option::unwrap_none()` on a `Some` value: "hello"', src/main.rs:8:29 ``` ```rust map.try_insert(10, "world").unwrap(); // thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: // OccupiedError { key: 10, old_value: "hello", new_value: "world" }', src/main.rs:6:33 ``` It also allows handling the failure in any other way, as you have full access to the `OccupiedEntry` and the value. `try_insert` returns a reference to the value in case of success, making it an alternative to `.entry(key).or_insert(value)`. r? ```@Amanieu``` Fixes rust-lang/rfcs#3092
Configuration menu - View commit details
-
Copy full SHA for 232caad - Browse repository at this point
Copy the full SHA 232caadView commit details -
Rollup merge of rust-lang#82770 - m-ou-se:assert-match, r=joshtriplett
Add assert_matches macro. This adds `assert_matches!(expression, pattern)`. Unlike the other asserts, this one ~~consumes the expression~~ may consume the expression, to be able to match the pattern. (It could add a `&` implicitly, but that's noticable in the pattern, and will make a consuming guard impossible.) See rust-lang#62633 (comment) This re-uses the same `left: .. right: ..` output as the `assert_eq` and `assert_ne` macros, but with the pattern as the right part: assert_eq: ``` assertion failed: `(left == right)` left: `Some("asdf")`, right: `None` ``` assert_matches: ``` assertion failed: `(left matches right)` left: `Ok("asdf")`, right: `Err(_)` ``` cc ```@cuviper```
Configuration menu - View commit details
-
Copy full SHA for 04045cc - Browse repository at this point
Copy the full SHA 04045ccView commit details -
Rollup merge of rust-lang#82773 - mgacek8:feature/add_diagnostic_item…
…_to_Default_trait, r=oli-obk Add diagnostic item to `Default` trait This PR adds diagnostic item to `Default` trait to be used by rust-lang/rust-clippy#6562 issue. Also fixes the obsolete path to the `symbols.rs` file in the comment.
Configuration menu - View commit details
-
Copy full SHA for 2cd1f79 - Browse repository at this point
Copy the full SHA 2cd1f79View commit details -
Rollup merge of rust-lang#82787 - notriddle:main-js-cleanup, r=Guilla…
…umeGomez Remove unused code from main.js It looks like `lev_distance` was used in a very old version of the function, since it was written but never read, and Blame reports that it was added before the `checkGenerics` function header itself. `convertHTMLToPlaintext` is was removed by 768d5e9
Configuration menu - View commit details
-
Copy full SHA for 16518e7 - Browse repository at this point
Copy the full SHA 16518e7View commit details