Rollup of 11 pull requests #82530
Merged
Rollup of 11 pull requests #82530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These ensure that these tests pass regardless of what RUST_BACKTRACE is set to in the user's shell.
Almost all safety comments are of the form `// SAFETY:`, so normalize the rest and fix a few of them that should have been a `/// # Safety` section instead. Furthermore, make `tidy` only allow the uppercase form. While currently `tidy` only checks `core`, it is a good idea to prevent `core` from drifting to non-uppercase comments, so that later we can start checking `alloc` etc. too. Signed-off-by: Miguel Ojeda <[email protected]>
- Currently style triggers rust-lang#81183 so we can't add `#[instrument]` to this function. - Having docs above the header is more consistent with the rest of the code base.
This avoids printing lots of unnecessary errors, as well as making the test suite slightly faster.
…pastorino Cleanup `PpMode` and friends This PR: - Separates `PpSourceMode` and `PpHirMode` to remove invalid states - Renames the variant to remove the redundant `Ppm` prefix - Adds basic documentation for the different pretty-print modes - Cleanups some code to make it more idiomatic Not sure if this is actually useful, but it looks cleaner to me.
Set RUST_BACKTRACE=0 when running `treat-err-as-bug` tests These ensure that these tests pass regardless of what RUST_BACKTRACE is set to in the user's shell.
…Gomez Fix typo in sanitizer flag in unstable book.
panic_bounds_checks should be panic_bounds_check
Update outdated comment in unix Command. The big comment in the `Command` struct has been incorrect for some time (at least since rust-lang#46789 which removed `envp`). Rather than try to remove the allocations, this PR just updates the comment to reflect reality. There is an explanation for the reasoning at rust-lang#31409 (comment), discussing the potential of being able to call `Command::exec` after `libc::fork`. That can still be done in the future, but I think for now it would be good to just correct the comment.
…s, r=kennytm library: Normalize safety-for-unsafe-block comments Almost all safety comments are of the form `// SAFETY:`, so normalize the rest and fix a few of them that should have been a `/// # Safety` section instead. Furthermore, make `tidy` only allow the uppercase form. While currently `tidy` only checks `core`, it is a good idea to prevent `core` from drifting to non-uppercase comments, so that later we can start checking `alloc` etc. too. Signed-off-by: Miguel Ojeda <[email protected]>
…etrochenkov Move pick_by_value_method docs above function header - Currently style triggers rust-lang#81183 so we can't add `#[instrument]` to this function. - Having docs above the header is more consistent with the rest of the code base.
rustdoc: Remove duplicate "List of all items" Closes rust-lang#82477 r? `@jyn514`
Only look for HTML `tidy` when running rustdoc tests This avoids printing lots of unnecessary errors, as well as making the test suite slightly faster. This doesn't fix the windows bug tracked by rust-lang#82501, though. r? `@petrochenkov`
fix typo in `pre-commit.sh` This updates a small typo I found, no more no less 🙂
Fix typo in `param_env_reveal_all_normalized` This made the generated docs look strange: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/context/struct.TyCtxt.html#method.param_env_reveal_all_normalized
|
@bors r+ p=11 |
|
📌 Commit 42e53ff has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
PpModeand friends #82269 (CleanupPpModeand friends)treat-err-as-bugtests #82431 (Set RUST_BACKTRACE=0 when runningtreat-err-as-bugtests)tidywhen running rustdoc tests #82502 (Only look for HTMLtidywhen running rustdoc tests)pre-commit.sh#82503 (fix typo inpre-commit.sh)param_env_reveal_all_normalized#82510 (Fix typo inparam_env_reveal_all_normalized)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup