Fix ES5 errors (IE11) #82145
Merged
Fix ES5 errors (IE11) #82145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
My reading of the browser minimums RFC was that it wasn't, Edge is the minimum supported Windows-builtin browser. |
GuillaumeGomez
force-pushed
the
es5-checks
branch
from
740d956
to
63bcf11
Compare
|
It always has been (well, until recent changes). The whole code has been made like this in order to support it after all. |
GuillaumeGomez
force-pushed
the
es5-checks
branch
from
63bcf11
to
7ab2439
Compare
GuillaumeGomez
force-pushed
the
es5-checks
branch
from
7ab2439
to
2f2d11e
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
es5-checks
branch
3 times, most recently
from
f1c1124
to
30f0c91
Compare
GuillaumeGomez
force-pushed
the
es5-checks
branch
2 times, most recently
from
68dd4e5
to
6a8809d
Compare
pickfire
approved these changes
Feb 15, 2021
pickfire
reviewed
Feb 15, 2021
jfrimmel
reviewed
Feb 15, 2021
GuillaumeGomez
force-pushed
the
es5-checks
branch
from
6a8809d
to
38a9f5d
Compare
|
Fixed the nits. Seems like it's ready @Mark-Simulacrum |
GuillaumeGomez
force-pushed
the
es5-checks
branch
from
38a9f5d
to
719c8d4
Compare
|
I removed the second commit and will open another PR so this fix can be merged quickly. @bors: r=Nemo157 rollup |
|
📌 Commit 719c8d4 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2021
ES5 checks rustdoc is supposed to run on IE11 but someone reported me that it wasn't. I just confirmed it by using `es-check` with the `es5` option like this: ``` $ es-check es5 src/librustdoc/html/static/*.js ``` The PR fixes those issues and add CI checks to prevent regressions. `@Mark-Simulacrum:` I added checks in the CI, but not sure if it's the correct way to do it. Any help on that side would be very appreciated! r? `@Nemo157`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 16, 2021
ES5 checks rustdoc is supposed to run on IE11 but someone reported me that it wasn't. I just confirmed it by using `es-check` with the `es5` option like this: ``` $ es-check es5 src/librustdoc/html/static/*.js ``` The PR fixes those issues and add CI checks to prevent regressions. ``@Mark-Simulacrum:`` I added checks in the CI, but not sure if it's the correct way to do it. Any help on that side would be very appreciated! r? ``@Nemo157``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2021
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#82145 (Fix ES5 errors (IE11)) - rust-lang#82160 (Fix typo in rustc_infer::infer::UndoLog) - rust-lang#82161 (Add long explanation for E0545) - rust-lang#82163 (avoid full-slicing slices) - rust-lang#82175 (validation: fix invalid-fn-ptr error message) - rust-lang#82184 ([Minor] Update discriminant_value docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 21, 2021
…k-Simulacrum Add check for ES5 in CI Follow-up of rust-lang#82145. r? `@Mark-Simulacrum`
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 21, 2021
…k-Simulacrum Add check for ES5 in CI Follow-up of rust-lang#82145. r? ``@Mark-Simulacrum``
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 21, 2021
…k-Simulacrum Add check for ES5 in CI Follow-up of rust-lang#82145. r? ```@Mark-Simulacrum```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustdoc is supposed to run on IE11 but someone reported me that it wasn't. I just confirmed it by using
es-checkwith thees5option like this:The PR fixes those issues and add CI checks to prevent regressions.
@Mark-Simulacrum: I added checks in the CI, but not sure if it's the correct way to do it. Any help on that side would be very appreciated!
r? @Nemo157