-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #81596
Rollup of 11 pull requests #81596
Commits on Jan 22, 2021
-
Don't link with --export-dynamic on wasm32-wasi
Remove --export-dynamic from the link arguments on the wasm32-wasi target, as it emits spurious exports and increases code size. Leave it in place for wasm32-unknown-unknown and wasm32-unknown-emscripten. Even though it isn't a great solution there, users are likely depending on its behavior there.
Configuration menu - View commit details
-
Copy full SHA for 9abcfa5 - Browse repository at this point
Copy the full SHA 9abcfa5View commit details
Commits on Jan 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fe39653 - Browse repository at this point
Copy the full SHA fe39653View commit details
Commits on Jan 29, 2021
-
Restrict precision of captures with
capture_disjoint_fields
set- No Derefs in move closure, this will result in value behind a reference getting moved. - No projections are applied to raw pointers, since these require unsafe blocks. We capture them completely. Motivations for these are recorded here: https://hackmd.io/71qq-IOpTNqzMkPpAI1dVg?view
Configuration menu - View commit details
-
Copy full SHA for b421cd5 - Browse repository at this point
Copy the full SHA b421cd5View commit details -
Compute mutability of closure captures
When `capture_disjoint_fields` is not enabled, checking if the root variable binding is mutable would suffice. However with the feature enabled, the captured place might be mutable because it dereferences a mutable reference. This PR computes the mutability of each capture after capture analysis in rustc_typeck. We store this in `ty::CapturedPlace` and then use `ty::CapturedPlace::mutability` in mir_build and borrow_check.
Configuration menu - View commit details
-
Copy full SHA for 3488082 - Browse repository at this point
Copy the full SHA 3488082View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1373f98 - Browse repository at this point
Copy the full SHA 1373f98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0897db5 - Browse repository at this point
Copy the full SHA 0897db5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 604cbdc - Browse repository at this point
Copy the full SHA 604cbdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c748f32 - Browse repository at this point
Copy the full SHA c748f32View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffd5327 - Browse repository at this point
Copy the full SHA ffd5327View commit details -
Configuration menu - View commit details
-
Copy full SHA for fadf03e - Browse repository at this point
Copy the full SHA fadf03eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f4bab2 - Browse repository at this point
Copy the full SHA 0f4bab2View commit details
Commits on Jan 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cddeb5e - Browse repository at this point
Copy the full SHA cddeb5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 642d27d - Browse repository at this point
Copy the full SHA 642d27dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f1a7aa - Browse repository at this point
Copy the full SHA 5f1a7aaView commit details -
Fix an old FIXME in redundant paren lint
Referenced bug was fixed a while ago
Configuration menu - View commit details
-
Copy full SHA for 8b5187f - Browse repository at this point
Copy the full SHA 8b5187fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9946b54 - Browse repository at this point
Copy the full SHA 9946b54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6946534 - Browse repository at this point
Copy the full SHA 6946534View commit details -
Edit multiple error code Markdown files
Makes small edits to several error code files. Fixes some missing punctuation. Changes some wording, grammar, and formatting for clarity and readability. Adds a link to the rustup book in E0658.
Configuration menu - View commit details
-
Copy full SHA for fabb332 - Browse repository at this point
Copy the full SHA fabb332View commit details
Commits on Jan 31, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6695690 - Browse repository at this point
Copy the full SHA 6695690View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8940a26 - Browse repository at this point
Copy the full SHA 8940a26View commit details -
Rollup merge of #80092 - sexxi-goose:restrict_precision, r=nikomatsakis
2229: Fix issues with move closures and mutability This PR fixes two issues when feature `capture_disjoint_fields` is used. 1. Can't mutate using a mutable reference 2. Move closures try to move value out through a reference. To do so, we 1. Compute the mutability of the capture and store it as part of the `CapturedPlace` that is written in TypeckResults 2. Restrict capture precision. Note this is temporary for now, to allow the feature to be used with move closures and ByValue captures and might change depending on discussions with the lang team. - No Derefs are captured for ByValue captures, since that will result in value behind a reference getting moved. - No projections are applied to raw pointers since these require unsafe blocks. We capture them completely. r? `````@nikomatsakis`````
Configuration menu - View commit details
-
Copy full SHA for 7e3a8ec - Browse repository at this point
Copy the full SHA 7e3a8ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99f2f5a - Browse repository at this point
Copy the full SHA 99f2f5aView commit details -
Rollup merge of #81255 - sunfishcode:wasi-no-export-dynamic, r=alexcr…
…ichton Don't link with --export-dynamic on wasm32-wasi Remove --export-dynamic from the link arguments on the wasm32-wasi target, as it emits spurious exports and increases code size. Leave it in place for wasm32-unknown-unknown and wasm32-unknown-emscripten. Even though it isn't a great solution there, users are likely depending on its behavior there.
Configuration menu - View commit details
-
Copy full SHA for ed56145 - Browse repository at this point
Copy the full SHA ed56145View commit details -
Rollup merge of #81480 - b-naber:nested_fields_suggestion, r=estebank
Add suggestion for nested fields Closes #81220 r? ```@estebank```
Configuration menu - View commit details
-
Copy full SHA for 991b313 - Browse repository at this point
Copy the full SHA 991b313View commit details -
Rollup merge of #81549 - est31:wording_fix, r=jonas-schievink
Misc ip documentation fixes
Configuration menu - View commit details
-
Copy full SHA for 47a5312 - Browse repository at this point
Copy the full SHA 47a5312View commit details -
Rollup merge of #81566 - osa1:issue71202, r=jonas-schievink
Add a test for #71202 Closes #71202 --- Note that the test normally generates this warning: ``` warning: cannot use constants which depend on generic parameters in types --> test.rs:10:5 | 10 | / const ITEM_IS_COPY: [(); 1 - { 11 | | trait NotCopy { 12 | | const VALUE: bool = false; 13 | | } ... | 26 | | <IsCopy<T>>::VALUE 27 | | } as usize] = []; | |_____________________^ | = note: `#[warn(const_evaluatable_unchecked)]` on by default = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #76200 <#76200> ``` I added `allow(const_evaluatable_unchecked)`, but maybe we just don't want to add a test for this as the program is not really valid?
Configuration menu - View commit details
-
Copy full SHA for 86732ff - Browse repository at this point
Copy the full SHA 86732ffView commit details -
Rollup merge of #81568 - osa1:remove_old_fixme, r=jonas-schievink
Fix an old FIXME in redundant paren lint Referenced bug was fixed a while ago
Configuration menu - View commit details
-
Copy full SHA for 024848d - Browse repository at this point
Copy the full SHA 024848dView commit details -
Rollup merge of #81571 - schteve:fix_e0759_typo, r=jonas-schievink
Fix typo in E0759 Minor typo in E0759 error message.
Configuration menu - View commit details
-
Copy full SHA for 86c01dd - Browse repository at this point
Copy the full SHA 86c01ddView commit details -
Rollup merge of #81572 - pierwill:edit-error-codes-1, r=jonas-schievink
Edit multiple error code Markdown files Makes small edits to several error code files. Fixes some missing punctuation. Changes some wording, grammar, and formatting for clarity and readability. Adds a link to the rustup book in E0658.
Configuration menu - View commit details
-
Copy full SHA for 36af32a - Browse repository at this point
Copy the full SHA 36af32aView commit details -
Rollup merge of #81589 - Seppel3210:master, r=jonas-schievink
Fix small typo in string.rs
Configuration menu - View commit details
-
Copy full SHA for 600b2d3 - Browse repository at this point
Copy the full SHA 600b2d3View commit details -
Rollup merge of #81590 - KodrAus:stabilize/int_bits_const, r=m-ou-se
Stabilize int_bits_const Closes #76904 The FCP to stabilize the `int_bits_const` feature completed on the tracking issue.
Configuration menu - View commit details
-
Copy full SHA for 9165676 - Browse repository at this point
Copy the full SHA 9165676View commit details