Add better diagnostic for unbounded Abst. Const #81544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
JulianKnodt
force-pushed
the
sat_where
branch
from
0d29d4d
to
2e7aa64
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
JulianKnodt
force-pushed
the
sat_where
branch
from
2e7aa64
to
74ae3f2
Compare
lcnr
reviewed
Jan 30, 2021
JulianKnodt
force-pushed
the
sat_where
branch
from
74ae3f2
to
260aa8d
Compare
JulianKnodt
changed the title
lcnr
reviewed
Jan 31, 2021
JulianKnodt
force-pushed
the
sat_where
branch
from
260aa8d
to
43052bd
Compare
lcnr
reviewed
Feb 2, 2021
Previously, it's not clear what exactly should be added in the suggested where clause, so this adds an example to demonstrate.
JulianKnodt
force-pushed
the
sat_where
branch
from
43052bd
to
6525671
Compare
|
@bors r+ rollup |
|
📌 Commit 6525671 has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Feb 2, 2021
Add better diagnostic for unbounded Abst. Const ~~In the case where a generic abst. const requires a trivial where bound: `where TypeWithConst<const_fn(N)>: ,`, instead of requiring a where bound, just check that only consts are being substituted in to skip over where check.~~ ~~This is pretty sketchy, but I think it works. Presumably, if there is checking for type bounds added later, it can first check nested requirements, and see if they're satisfied by the current `ParamEnv`.~~ Changed the diagnostic to add a better example, which is more practical than what was previously proposed. r? `@lcnr`
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Feb 2, 2021
Add better diagnostic for unbounded Abst. Const ~~In the case where a generic abst. const requires a trivial where bound: `where TypeWithConst<const_fn(N)>: ,`, instead of requiring a where bound, just check that only consts are being substituted in to skip over where check.~~ ~~This is pretty sketchy, but I think it works. Presumably, if there is checking for type bounds added later, it can first check nested requirements, and see if they're satisfied by the current `ParamEnv`.~~ Changed the diagnostic to add a better example, which is more practical than what was previously proposed. r? ``@lcnr``
This was referenced Feb 2, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 2, 2021
Rollup of 14 pull requests Successful merges: - rust-lang#80593 (Upgrade Chalk) - rust-lang#81260 (Add .editorconfig) - rust-lang#81455 (Add AArch64 big-endian and ILP32 targets) - rust-lang#81517 (Remove remnants of the santizer runtime crates from bootstrap) - rust-lang#81530 (sys: use `process::abort()` instead of `arch::wasm32::unreachable()`) - rust-lang#81544 (Add better diagnostic for unbounded Abst. Const) - rust-lang#81588 (Add doc aliases for "delete") - rust-lang#81603 (rustbuild: Don't build compiler twice for error-index-generator.) - rust-lang#81634 (Add long explanation e0521) - rust-lang#81636 (Directly use `Option<&[T]>` instead of converting from `Option<&Vec<T>>` later on) - rust-lang#81647 (Fix bug with assert!() calling the wrong edition of panic!().) - rust-lang#81655 (Improve wording of suggestion about accessing field) - rust-lang#81665 (Fix out of date `Scalar` documentation) - rust-lang#81671 (Add more associated type tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where a generic abst. const requires a trivial where bound:where TypeWithConst<const_fn(N)>: ,,instead of requiring a where bound, just check that only consts are being substituted in to skip over where check.
This is pretty sketchy, but I think it works. Presumably, if there is checking for type bounds added later, it can first check nested requirements, and see if they're satisfied by the currentParamEnv.Changed the diagnostic to add a better example, which is more practical than what was previously proposed.
r? @lcnr