Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When snapshoting a TokenCursor, preserve the top frame of the stack #81352

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions compiler/rustc_parse/src/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1260,9 +1260,11 @@ impl<'a> Parser<'a> {
let start_token = (self.token.clone(), self.token_spacing);
let cursor_snapshot = TokenCursor {
frame: self.token_cursor.frame.clone(),
// We only ever capture tokens within our current frame,
// so we can just use an empty frame stack
stack: vec![],
// If we start collecting on the first token of a frame
// (e.g. the '{' in '{ my_tokens }'), then we can legally
// exit the frame (e.g. collecting '{ my_tokens } something_else'
// Therefore, we preserve the top of the stack, but nothing else
stack: self.token_cursor.stack.first().cloned().into_iter().collect(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stack: self.token_cursor.stack.first().cloned().into_iter().collect(),
stack: if self.token_cursor.stack.is_empty() { vec![] } else { vec![TokenCursorFrame::dummy()] }

I'm not actually sure, does it matter what exactly we put into the stack here, or putting any dummy frame making stack.pop() work without panic would be enough?

I'm asking because first() is not the top of the stack, it's the bottom, but things still seem to work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's a good point. I'll need to take a closer look at how this is working.

desugar_doc_comments: self.token_cursor.desugar_doc_comments,
num_next_calls: self.token_cursor.num_next_calls,
append_unglued_token: self.token_cursor.append_unglued_token.clone(),
Expand Down
23 changes: 23 additions & 0 deletions src/test/ui/proc-macro/auxiliary/nonterminal-recollect-attr.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// force-host
// no-prefer-dynamic

#![crate_type = "proc-macro"]
#![feature(proc_macro_quote)]

extern crate proc_macro;
use proc_macro::{TokenStream, quote};

#[proc_macro_attribute]
pub fn first_attr(_: TokenStream, input: TokenStream) -> TokenStream {
let recollected: TokenStream = input.into_iter().collect();
quote! {
#[second_attr]
$recollected
}
}

#[proc_macro_attribute]
pub fn second_attr(_: TokenStream, input: TokenStream) -> TokenStream {
let _recollected: TokenStream = input.into_iter().collect();
TokenStream::new()
}
17 changes: 17 additions & 0 deletions src/test/ui/proc-macro/nonterminal-recollect-attr.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// check-pass
// aux-build:nonterminal-recollect-attr.rs

extern crate nonterminal_recollect_attr;
use nonterminal_recollect_attr::*;

macro_rules! my_macro {
($v:ident) => {
#[first_attr]
$v struct Foo {
field: u8
}
}
}

my_macro!(pub);
fn main() {}