-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't display mut
in arguments for functions documentation
#81328
Conversation
e05f2c5
to
937bf18
Compare
This comment has been minimized.
This comment has been minimized.
@LeSeulArtichaut it looks the change might not have worked, the test is failing. This looks good to me, but I know petrochenkov wants to use rustc_hir_pretty as little as possible, so Note that the alternative here is to rewrite half of rustc_hir_pretty (i.e. revert #80799), so I would prefer not to do that. |
This is actually really dumb: I think the test is failing because of the source link to the file which contains |
937bf18
to
9dabead
Compare
This comment has been minimized.
This comment has been minimized.
9dabead
to
5b82898
Compare
I suggest reverting #80799 instead and not using HIR pretty-printing in rustdoc (and perhaps simplifying The goal of HIR pretty-printing is to print something suitable for debugging, the goal of rustdoc is printing argument names in a way presentable to users. |
@LeSeulArtichaut do you want to be the one to do the revert? |
Sure. |
…melid Don't display `mut` in arguments for functions documentation Fixes rust-lang#81289 by reverting rust-lang#80799, as requested in rust-lang#81328 (comment). Supersedes rust-lang#81328. r? `@camelid` cc `@jyn514`
…melid Don't display `mut` in arguments for functions documentation Fixes rust-lang#81289 by reverting rust-lang#80799, as requested in rust-lang#81328 (comment). Supersedes rust-lang#81328. r? ``@camelid`` cc ``@jyn514``
This mostly touches
rustc_hir_pretty
, I don't know who should review this.Fixes #81289.
r? @jyn514