Fix file descriptor ranges for fuchsia #81226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuchsia does not restrict the range of valid values for a file descriptor, so the previous change that marked -1 as an invalid file descriptor does not apply to fuchsia.
|
r? @cramertj (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
CC @tmandry |
Nashenas88
commented
Jan 21, 2021
|
cc #74699 which introduced the niche at -1 I'll add that we'd like to support this and remove the special case if possible, but we have unit tests that fail the assertion currently. |
tmandry
approved these changes
Jan 21, 2021
|
Why is Fuchsia being treated as different from other POSIX-like operating systems in this regard? File descriptors work the same way on Fuchsia as they do on other POSIX-like operating systems. |
Shouldn't we fix those unit tests rather than change rust-lang to be incorrect? |
|
Closing since this was not needed. The fix was done on the fuchsia side at https://fuchsia-review.googlesource.com/c/fuchsia/+/473984. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuchsia does not restrict the range of valid values for a file descriptor, so the previous change that marked -1 as an invalid file descriptor does not apply to fuchsia.