-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit rustc_middle::dep_graph module documentation #81130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 17, 2021
r? @cjgillot |
jyn514
added
A-contributor-roadblock
Area: Makes things more difficult for new contributors to rust itself
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
labels
Jan 17, 2021
jyn514
reviewed
Jan 17, 2021
camelid
reviewed
Jan 19, 2021
jyn514
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with nit fixed
Co-authored-by: Joshua Nelson <[email protected]> Co-authored-by: Camelid <[email protected]>
@bors r+ rolllup |
📌 Commit b29353a has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 23, 2021
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 23, 2021
…as-schievink Rollup of 15 pull requests Successful merges: - rust-lang#79841 (More clear documentation for NonNull<T>) - rust-lang#81072 (PlaceRef::ty: use method call syntax) - rust-lang#81130 (Edit rustc_middle::dep_graph module documentation) - rust-lang#81170 (Avoid hash_slice in VecDeque's Hash implementation) - rust-lang#81243 (mir: Improve size_of handling when arg is unsized) - rust-lang#81245 (Update cargo) - rust-lang#81249 (Lower closure prototype after its body.) - rust-lang#81252 (Add more self-profile info to rustc_resolve) - rust-lang#81275 (Fix <unknown> queries and add more timing info to render_html) - rust-lang#81281 (Inline methods of Path and OsString) - rust-lang#81283 (Note library tracking issue template in tracking issue template.) - rust-lang#81285 (Remove special casing of rustdoc in rustc_lint) - rust-lang#81288 (rustdoc: Fix visibility of trait and impl items) - rust-lang#81298 (replace RefCell with Cell in FnCtxt) - rust-lang#81301 (Fix small typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-contributor-roadblock
Area: Makes things more difficult for new contributors to rust itself
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to work approved and then closed in #80325 due to a bad rebase.