Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an empty TokenCursorFrame stack when capturing tokens #80830

Merged
merged 1 commit into from
Jan 9, 2021

Conversation

Aaron1011
Copy link
Member

We will never need to pop past our starting frame during token
capturing. Using an empty stack allows us to avoid pointless heap
allocations/deallocations.

We will never need to pop  past our starting frame during token
capturing. Using an empty stack allows us to avoid pointless heap
allocations/deallocations.
@rust-highfive
Copy link
Collaborator

r? @ecstatic-morse

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Jan 8, 2021

⌛ Trying commit 7b36408 with merge e63d87c7d985a3b28c39a68e1772b35a5cc24e72...

@bors
Copy link
Contributor

bors commented Jan 9, 2021

☀️ Try build successful - checks-actions
Build commit: e63d87c7d985a3b28c39a68e1772b35a5cc24e72 (e63d87c7d985a3b28c39a68e1772b35a5cc24e72)

@rust-timer
Copy link
Collaborator

Queued e63d87c7d985a3b28c39a68e1772b35a5cc24e72 with parent 26438b4, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 9, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (e63d87c7d985a3b28c39a68e1772b35a5cc24e72): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 9, 2021
@petrochenkov
Copy link
Contributor

r? @petrochenkov

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 9, 2021

📌 Commit 7b36408 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2021
@bors
Copy link
Contributor

bors commented Jan 9, 2021

⌛ Testing commit 7b36408 with merge 6184f23...

@bors
Copy link
Contributor

bors commented Jan 9, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 6184f23 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 9, 2021
@bors bors merged commit 6184f23 into rust-lang:master Jan 9, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 9, 2021
Aaron1011 added a commit to Aaron1011/rust that referenced this pull request Jan 28, 2021
Reverts PR rust-lang#80830
Fixes taiki-e/pin-project#312

We can have an arbitrary number of `None`-delimited group frames pushed
on the stack due to proc-macro invocations, which can legally be exited.
Attempting to account for this would add a lot of complexity for a tiny
performance gain, so let's just use the original strategy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants