Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #80790

Merged
merged 28 commits into from
Jan 7, 2021
Merged

Rollup of 10 pull requests #80790

merged 28 commits into from
Jan 7, 2021

Commits on Jan 3, 2021

  1. Edit rustc_ast::tokenstream docs

    Fix some punctuation and wording, and add intra-documentation links.
    pierwill committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    9a240e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. fix issue 80559

    max-heller committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    b4a0ef0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e33a205 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fc3a405 View commit details
    Browse the repository at this point in the history
  4. half working

    max-heller committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    06b0900 View commit details
    Browse the repository at this point in the history
  5. Inlining enabled by -mir-opt-level > 1 is incompatible with coverage

    Fixes: rust-lang#80060
    
    Also adds additional test cases for coverage of doctests.
    richkadel committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    e4aa99f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6f04133 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Configuration menu
    Copy the full SHA
    2bdbb0d View commit details
    Browse the repository at this point in the history
  2. Remove bottom margin from crate version when the sidebar is collapsed.

    This fixes a mobile UI bug where a vertical scrollbar would always be
    rendered on the sidebar nav when the menu was closed.
    arusahni committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    aea9a4b View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Configuration menu
    Copy the full SHA
    e636805 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Joshua Nelson <[email protected]>
    camelid and Joshua Nelson authored Jan 6, 2021
    Configuration menu
    Copy the full SHA
    7428e2d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7bc22e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Improve wording of parse doc

    Change:
    ```
    `parse` can parse any type that...
    ```
    to:
    ```
    `parse` can parse into any type that...
    ```
    Word `into` added to be more precise and in coherence with other parts of the doc.
    ejez authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2b8109f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f03907b View commit details
    Browse the repository at this point in the history
  3. bless tests

    sasurau4 committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    c9e7045 View commit details
    Browse the repository at this point in the history
  4. Refine E0435 description

    sasurau4 committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    c71348a View commit details
    Browse the repository at this point in the history
  5. Return EOF_CHAR constant instead of magic char.

    Hanzhen Liang committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    f942c3c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0dab076 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#80012 - sasurau4:feature/point-constant-ide…

    …ntifier-E0435, r=petrochenkov
    
    Add pointing const identifier when emitting E0435
    
    Fix rust-lang#79919
    JohnTitor authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    bb229b8 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#80521 - richkadel:llvm-coverage-counters-2.…

    …4.0, r=wesleywiser
    
    MIR Inline is incompatible with coverage
    
    Fixes: rust-lang#80060
    
    Fixed by disabling inlining if `-Zinstrument-coverage` is set.
    
    The PR also adds additional use cases to the coverage test for doctests.
    
    r? `@wesleywiser`
    cc: `@tmandry`
    JohnTitor authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    3acd75d View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#80659 - pierwill:edit-tokenstream, r=davidtwco

    Edit rustc_ast::tokenstream docs
    
    Fix some punctuation and wording, and add intra-documentation links.
    JohnTitor authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d02b31c View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#80660 - max-heller:issue-80559-fix, r=jyn514

    Properly handle primitive disambiguators in rustdoc
    
    Fixes rust-lang#80559
    
    r? ``@jyn514``
    
    Is there a way to test that the generated intra-doc link is what I expect?
    JohnTitor authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2e9788b View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#80738 - arusahni:master, r=GuillaumeGomez

    Remove bottom margin from crate version when the docs sidebar is collapsed
    
    This fixes a mobile UI bug where a vertical scrollbar would always be
    rendered on the sidebar nav when the menu was closed.  When opened, the overflow would be handled by the opened sidebar, causing the scrollbar to disappear, and the contents to shift to the right.
    
    ## Firefox
    **Before**
    ![before-ff](https://user-images.githubusercontent.com/139487/103713599-c2f74c00-4f8a-11eb-88c0-d5c6c088f8a0.png)
    ![before](https://user-images.githubusercontent.com/139487/103713793-2bdec400-4f8b-11eb-8223-94b77cc05f71.gif)
    
    **After**
    ![after-ff](https://user-images.githubusercontent.com/139487/103713605-c8ed2d00-4f8a-11eb-9ee8-f86cafaa8775.png)
    ![after](https://user-images.githubusercontent.com/139487/103713805-31d4a500-4f8b-11eb-9e5b-4156402ca43e.gif)
    
    ## Chrome
    **Before**
    ![localhost_8000_unicode_xid_ (1)](https://user-images.githubusercontent.com/139487/103713626-d60a1c00-4f8a-11eb-8605-cc98e04e9ad0.png)
    
    **After**
    ![localhost_8000_unicode_xid_](https://user-images.githubusercontent.com/139487/103713622-d1456800-4f8a-11eb-8c66-7d19f81614ca.png)
    JohnTitor authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    94a27f2 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#80744 - camelid:next_def_id-docs, r=jyn514

    rustdoc: Turn `next_def_id` comments into docs
    
    Split out from rust-lang#80740.
    
    r? ``@jyn514``
    JohnTitor authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    6fb7924 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#80750 - GuillaumeGomez:cleanup-to_string, r…

    …=lzutao
    
    Don't use to_string on Symbol in rustc_passes/check_attr.rs
    
    Improve code from rust-lang#80686.
    
    r? ``@lzutao``
    JohnTitor authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    fd7f244 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#80769 - ejez:patch-1, r=jonas-schievink

    Improve wording of parse doc
    
    Change:
    ```
    `parse` can parse any type that...
    ```
    to:
    ```
    `parse` can parse into any type that...
    ```
    Word `into` added to be more precise and in coherence with other parts of the doc.
    JohnTitor authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    a97dc5f View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#80780 - lianghanzhen:master, r=petrochenkov

    Return EOF_CHAR constant instead of magic char.
    JohnTitor authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    695f18e View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#80784 - petrochenkov:nontspan, r=Aaron1011

    rustc_parse: Better spans for synthesized token streams
    
    I think using the nonterminal span for synthesizing its tokens is a better approximation than using `DUMMY_SP` or the attribute span like rust-lang#79472 did in `expand.rs`.
    
    r? `@Aaron1011`
    JohnTitor authored Jan 7, 2021
    Configuration menu
    Copy the full SHA
    695f878 View commit details
    Browse the repository at this point in the history