Always run intrinsics lowering pass #80040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
📌 Commit 1b74a82 has been approved by |
bors
added
S-waiting-on-bors
Move intrinsics lowering pass from the optimization phase (where it would not run if -Zmir-opt-level=0), to the drop lowering phase where it runs unconditionally. The implementation of those intrinsics in code generation and interpreter is unnecessary. Remove it.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 15, 2020
…nagisa Always run intrinsics lowering pass Move intrinsics lowering pass from the optimization phase (where it would not run if -Zmir-opt-level=0), to the drop lowering phase where it runs unconditionally. The implementation of those intrinsics in code generation and interpreter is unnecessary. Remove it.
tmiasko
force-pushed
the
always-lower-intrinsics
branch
from
1b74a82
to
a9ff4bd
Compare
|
I updated the test output to account for changes from #79922 (but I am leaving the |
|
failed in CI anyway |
bors
added
S-waiting-on-author
|
@Dylan-DPC the current version should account for rollup CI failure. |
|
📌 Commit a9ff4bd has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 15, 2020
…Dylan-DPC Always run intrinsics lowering pass Move intrinsics lowering pass from the optimization phase (where it would not run if -Zmir-opt-level=0), to the drop lowering phase where it runs unconditionally. The implementation of those intrinsics in code generation and interpreter is unnecessary. Remove it.
This was referenced Dec 15, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 15, 2020
…Dylan-DPC Always run intrinsics lowering pass Move intrinsics lowering pass from the optimization phase (where it would not run if -Zmir-opt-level=0), to the drop lowering phase where it runs unconditionally. The implementation of those intrinsics in code generation and interpreter is unnecessary. Remove it.
|
cc @RalfJung and @oli-obk (part of @rust-lang/miri which I can't ping) per this comment. They might have objections and/or may need to adjust Miri accordingly. |
|
This LGTM, and thanks for the heads-up! I'll update Miri once this lands. When more intrinsics are added to the lowering pass, please let me know. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 17, 2020
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#80006 (BTreeMap: more expressive local variables in merge) - rust-lang#80022 (BTreeSet: simplify implementation of pop_first/pop_last) - rust-lang#80035 (Optimization for bool's PartialOrd impl) - rust-lang#80040 (Always run intrinsics lowering pass) - rust-lang#80047 (Use more symbols in rustdoc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bjorn3
added a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Dec 18, 2020
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Dec 22, 2020
remove intrinsic that is now implemented in the rustc side Since rust-lang/rust#80040, we can rely on the pass introduced in rust-lang/rust#79049 to lower away `forget`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move intrinsics lowering pass from the optimization phase (where it
would not run if -Zmir-opt-level=0), to the drop lowering phase where it
runs unconditionally.
The implementation of those intrinsics in code generation and
interpreter is unnecessary. Remove it.