-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(array,vec): add notes about side effects when empty-initializing #79918
Merged
bors
merged 2 commits into
rust-lang:master
from
woodruffw-forks:ww/doc-initializer-side-effects
Dec 14, 2020
Merged
doc(array,vec): add notes about side effects when empty-initializing #79918
bors
merged 2 commits into
rust-lang:master
from
woodruffw-forks:ww/doc-initializer-side-effects
Dec 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 10, 2020
scottmcm
reviewed
Dec 11, 2020
jyn514
added
the
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
label
Dec 11, 2020
dtolnay
approved these changes
Dec 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ rollup |
📌 Commit d986924 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 13, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 14, 2020
…side-effects, r=dtolnay doc(array,vec): add notes about side effects when empty-initializing Copying some context from a conversation in the Rust discord: * Both `vec![T; 0]` and `[T; 0]` are syntactically valid, and produce empty containers of their respective types * Both *also* have side effects: ```rust fn side_effect() -> String { println!("side effect!"); "foo".into() } fn main() { println!("before!"); let x = vec![side_effect(); 0]; let y = [side_effect(); 0]; println!("{:?}, {:?}", x, y); } ``` produces: ``` before! side effect! side effect! [], [] ``` This PR just adds two small notes to each's documentation, warning users that side effects can occur. I've also submitted a clippy proposal: rust-lang/rust-clippy#6439
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 14, 2020
…laumeGomez Rollup of 3 pull requests Successful merges: - rust-lang#79918 (doc(array,vec): add notes about side effects when empty-initializing) - rust-lang#79936 (Fix item name display on mobile) - rust-lang#80013 (Refactor test_lang_string_parse to make it clearer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying some context from a conversation in the Rust discord:
Both
vec![T; 0]
and[T; 0]
are syntactically valid, and produce empty containers of their respective typesBoth also have side effects:
produces:
This PR just adds two small notes to each's documentation, warning users that side effects can occur.
I've also submitted a clippy proposal: rust-lang/rust-clippy#6439