Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tab-lock and replace it with ctrl+up/down arrows to switch between search result tabs #79862

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Remove tab-lock and replace it with ctrl+up/down arrows to switch between search result tabs #79862

merged 1 commit into from
Dec 10, 2020

Conversation

GuillaumeGomez
Copy link
Member

Fixes #65212

What took the longest time was to update the help popup in the end.

r? @Manishearth

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2020
@Manishearth
Copy link
Member

@bors r+

looks just about what i'd expect, thanks for making the changes! I'll play around with this locally later and make any followup PRs if necessary.

@bors
Copy link
Contributor

bors commented Dec 9, 2020

📌 Commit 570de0a has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2020
@tmandry tmandry mentioned this pull request Dec 9, 2020
Merged
@jyn514 jyn514 added A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 9, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2020
@bors
Auto merge of rust-lang#79867 - tmandry:rollup-7mubs3b, r=tmandry
1cc4107 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#79732 (minor stylistic clippy cleanups)
 - rust-lang#79750 (Fix trimming of lint docs)
 - rust-lang#79777 (Remove `first_merge` from liveness debug logs)
 - rust-lang#79795 (Privatize some of libcore unicode_internals)
 - rust-lang#79803 (Update xsv to prevent random CI failures)
 - rust-lang#79810 (Account for gaps in def path table during decoding)
 - rust-lang#79818 (Fixes to Rust coverage)
 - rust-lang#79824 (Strip prefix instead of replacing it with empty string)
 - rust-lang#79826 (Simplify visit_{foreign,trait}_item)
 - rust-lang#79844 (Move RWUTable to a separate module)
 - rust-lang#79861 (Update LLVM submodule)
 - rust-lang#79862 (Remove tab-lock and replace it with ctrl+up/down arrows to switch between search result tabs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@camelid
Copy link
Member

camelid commented Dec 9, 2020

Hmm, IIUC this will not work on macOS because the OS window manager assigns a meaning to Ctrl-up/down. Unless will the JS override the system meaning?

@GuillaumeGomez
Copy link
Member Author

I think @Manishearth wants to prioritize this as much as possible in order to fix the current situation. Can you open an issue and ping me on it so I can take a look once this is merged please?

@Manishearth
Copy link
Member

Hmm, IIUC this will not work on macOS because the OS window manager assigns a meaning to Ctrl-up/down. Unless will the JS override the system meaning?

The JS will since we preventDefault(). Whether or not that's okay is something we should ask MacOS users. I typically err on the side of not overriding system shortcuts.

@camelid camelid mentioned this pull request Dec 9, 2020
Closed
@bors bors merged commit f74f3b2 into rust-lang:master Dec 10, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 10, 2020
@GuillaumeGomez GuillaumeGomez deleted the tab-lock branch December 10, 2020 09:10
@GuillaumeGomez
Copy link
Member Author

The JS will since we preventDefault(). Whether or not that's okay is something we should ask MacOS users. I typically err on the side of not overriding system shortcuts.

I was thinking about using cmd in case we were on mac to prevent that. I'll check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

Potentially swap arrow keys and tab in rustdoc keyboard shortcuts
7 participants
@GuillaumeGomez @rust-highfive @Manishearth @bors @camelid @jyn514 @rustbot