Adding diesel to the cargetest suite #79599
Conversation
This was proposed in rust-lang#79459 and rust-lang#79560. Diesel stresses the trait system implementation quite a lot and there have been various regressions regarding that in the past.
This comment has been minimized.
This comment has been minimized.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
added
A-testsuite
| // Test the embeded sqlite variant of diesel | ||
| // This does not require any dependency to be present, | ||
| // sqlite will be compiled as part of the build process | ||
| features: Some(&["sqlite", "libsqlite3-sys/bundled"]), |
There was a problem hiding this comment.
How long does this take to compile?
There was a problem hiding this comment.
A clean build takes ~1min on my not really powerful laptop and maybe ~1 minutes to run all tests.
There was a problem hiding this comment.
Yeah, that sounds fine, thanks :)
|
At some point it might also be interesting to add diesel to rustc-perf, but that doesn't necessarily have to happen now. |
That was already proposed here. I will try to have a look there as soon I've find some time. Diesel should definitively be an interesting workload there as it does spend most compile time inside of rustc and not in llvm. (At least that was the case last time I've looked at why does take that much time to compile). |
|
I don't think we should be expanding the set of crates in the cargotest suite until we have a T-compiler/T-infra FCP'd policy about how additions should get reviewed (e.g., who approves? how?). So I'm going to close this for now, but I'd love to see such a policy written; the first step would be to draft something reasonable and file an MCP to discuss that I think. |
|
@Mark-Simulacrum Who is the correct person to get in touch with to discuss creating such a policy? As already mentioned there where multiple diesel related issues in the last weeks + some more in the last year so this seems to be a good test case + diesel is also used as port of the official rust infrastructure (crates.io) |
|
@weiznich you can open an MCP here: https://github.com/rust-lang/compiler-team/issues/new/choose but in general I think @Mark-Simulacrum 's point is that it isn't clear who to get in contact with and he's not comfortable making the decision unilaterally. |
|
Well then lets talk about it at the team meeting. Nominating for discussion, in terms of the one-off situation of this particular test addition. (The more general policy can also be discussed, but I don't want that general discussion to distract from making a decision here.) |
|
reopened as PR #81507, so I'll nominate that for discussion. |
…Mark-Simulacrum Adding diesel to the cargotest suite As discussed in rust-lang#79560 (comment) this adds diesel to the compilers test suite. This is basically a reopened version of rust-lang#79599, but now with the backing of the compiler team. r? `@pnkfelix`
This was proposed in #79459 and #79560.
Diesel stresses the trait system implementation quite a lot and there
have been various regressions regarding that in the past.