Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errors about #[deprecated] attribute #78626

Merged
merged 5 commits into from
Nov 3, 2020
Merged

Improve errors about #[deprecated] attribute #78626

merged 5 commits into from
Nov 3, 2020

Commits on Nov 1, 2020

  1. Deny #[deprecated] on trait impl blocks. 

    They have no effect there, but were silently accepted.
    @m-ou-se
    m-ou-se committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    0e2337a View commit details
    Browse the repository at this point in the history

  2. Use the right span for errors about #[deprecated] attributes.

    @m-ou-se
    m-ou-se committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    706bc33 View commit details
    Browse the repository at this point in the history

  3. Turn 'useless #[deprecated]' error into a lint.

    @m-ou-se
    m-ou-se committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    6f1992a View commit details
    Browse the repository at this point in the history

  4. Add test for #[deprecated] attribute on trait impl block.

    @m-ou-se
    m-ou-se committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    9fc991a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. Improve deprecation attribute diagnostic messages. 

    (From the PR feedback.)

Co-authored-by: Esteban Küber <[email protected]>
    @m-ou-se @estebank
    m-ou-se and estebank committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    9c647d1 View commit details
    Browse the repository at this point in the history