Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement -Z relax-elf-relocations=yes|no #78605

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

nox
Copy link
Contributor

@nox nox commented Oct 31, 2020

This lets rustc users tweak whether the linker should relax ELF relocations without recompiling a whole new target with its own libcore etc.

This lets rustc users tweak whether the linker should relax ELF relocations,
namely whether it should emit R_X86_64_GOTPCRELX relocations instead of
R_X86_64_GOTPCREL, as the former is allowed by the ABI to be further
optimised. The default value is whatever the target defines.
@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2020
@eddyb
Copy link
Member

eddyb commented Nov 1, 2020

r? @nagisa cc @alexcrichton

@rust-highfive rust-highfive assigned nagisa and unassigned varkor Nov 1, 2020
@nagisa
Copy link
Member

nagisa commented Nov 1, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 1, 2020

📌 Commit 6febaf2 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2020
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 1, 2020
Implement -Z relax-elf-relocations=yes|no

This lets rustc users tweak whether the linker should relax ELF relocations without recompiling a whole new target with its own libcore etc.
@bors
Copy link
Contributor

bors commented Nov 2, 2020

⌛ Testing commit 6febaf2 with merge 3d0682b...

@bors
Copy link
Contributor

bors commented Nov 2, 2020

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 3d0682b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 2, 2020
@bors bors merged commit 3d0682b into rust-lang:master Nov 2, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants