-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BTreeMap: move generic support functions out of navigate.rs #78359
Conversation
Note this would be another benign conflict postponing #78015 (because of the alphabetically close new module names), but to me it seems sensible to do it first. |
☔ The latest upstream changes (presumably #78015) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
Oh, hm, I did not see this before that other PR. If you want to ping me on Zulip to just say "please review in this order" or whatever, that's fine by me -- otherwise I usually go in oldest first order in my waiting-on-review queue. |
r=me though on the change itself (I think I approved a similar commit elsewhere, IIRC a bit smaller but I might be misremembering) |
17a4c43
to
0da7941
Compare
@bors r+ rollup=never |
📌 Commit 0da7941 has been approved by |
☀️ Test successful - checks-actions |
A preparatory step chipped off #78104, useful in general (if at all).
r? @Mark-Simulacrum