-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wip]Tentative add alloc::io module. #77922
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
81aa91d
to
5a33b12
Compare
This looks like a copy/paste of I recommend going through an RFC process or https://internals.rust-lang.org/ if you're interested in this change, but it will need a lot of design and a rationale for why it's useful. This PR as-is is unlikely to be merged. |
Thanks, this tentative, I have already removed the operating system part from alloc::io, I placed it under io because std::io depends on alloc, so I didn't place it under core::io. |
☔ The latest upstream changes (presumably #76885) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
This comment has been minimized.
This comment has been minimized.
Fixes it first. Add versions for ctypes.rs Improve ctypes.rs
☔ The latest upstream changes (presumably #82249) made this pull request unmergeable. Please resolve the merge conflicts. |
@lygstate can you resolve the conflicts? |
@Dylan-DPC Currently it's depends on #77384 |
closing this as this depends on a draft, which is going to take some time to get merged and it would probably be easier to open a fresh pr instead of solving all the conflicts that will accumulate by then. |
At the current stage, just copy std::io into alloca::io and
Get std::io to be an core::io component so that can be used by runtime implemenation.
Especially for posix libc implemenation in rust with
and so on.
This is for https://github.com/redox-os/relibc
Also for
https://github.com/rulibc/rulibc
The fork of relibc that act as an msvcrt/mingw/cygwin/msys2 alternative on win32
glibc/musl alternative on linux world.
redox support will alomost unchanged with the upstream Thttps://github.com/redox-os/relibc
And makes platform dependent IoSliceMut can be customized by the user
And give the default impl for windows/posix.
#36193
related
Depends on
rust-lang/project-error-handling#3
#77384