Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce no-move rule of ReentrantMutex using Pin and fix UB in stdio #77801

Merged
merged 4 commits into from
Dec 11, 2020
Merged

Enforce no-move rule of ReentrantMutex using Pin and fix UB in stdio #77801

merged 4 commits into from
Dec 11, 2020

Commits on Dec 8, 2020

  1. Fix outdated comment about not needing to flush stderr.

    @m-ou-se
    m-ou-se committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    2bc5d44 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary import of crate::marker in std::sys_common::remu… 

    …tex.

It was used for marker::Send, but Send is already in scope.
    @m-ou-se
    m-ou-se committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    9dc7f13 View commit details
    Browse the repository at this point in the history

  3. Add (internal-only) SyncOnceCell::get_or_init_pin.

    @m-ou-se
    m-ou-se committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    8fe9096 View commit details
    Browse the repository at this point in the history

  4. Use Pin for the 'don't move' requirement of ReentrantMutex. 

    The code in io::stdio before this change misused the ReentrantMutexes,
by calling init() on them and moving them afterwards. Now that
ReentrantMutex requires Pin for init(), this mistake is no longer easy
to make.
    @m-ou-se
    m-ou-se committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    67c18fd View commit details
    Browse the repository at this point in the history