Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print lints from plugins, if they're available #77671

Merged
merged 6 commits into from
Nov 26, 2020

Commits on Nov 24, 2020

  1. Configuration menu
    Copy the full SHA
    be1e502 View commit details
    Browse the repository at this point in the history
  2. Always print lints from plugins, if they're available

    Currently you can get a list of lints and lint groups by running `rustc
    -Whelp`. This prints an additional line at the end:
    ```
    Compiler plugins can provide additional lints and lint groups. To see a
    listing of these, re-run `rustc -W help` with a crate filename.
    ```
    
    Clippy is such a "compiler plugin", that provides additional lints.
    Running `clippy-driver -Whelp` (`rustc` wrapper) still only prints the
    rustc lints with the above message at the end. But when running
    `clippy-driver -Whelp main.rs`, where `main.rs` is any rust file, it
    also prints Clippy lints. I don't think this is a good approach from a
    UX perspective: Why is a random file necessary to print a help message?
    
    This commit changes this behavior: Whenever a compiler callback
    registers lints, it is assumed that these lints come from a plugin and
    are printed without having to specify a Rust source file.
    flip1995 committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    4daa263 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    13db749 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    364f5a2 View commit details
    Browse the repository at this point in the history
  5. clippy: Remove now obsolete lintlist module

    Also stop updating the lintlist module in clippy_dev update_lints
    flip1995 committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    f4fb47b View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. Configuration menu
    Copy the full SHA
    e54c060 View commit details
    Browse the repository at this point in the history