Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FIXME in core::num test: Check sign of zero in min/max tests. #77167

Merged

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Sep 24, 2020

r? nagisa

@rustbot modify labels: +C-cleanup

@rustbot rustbot added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Sep 24, 2020
@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2020
@m-ou-se

This comment has been minimized.

@rust-highfive rust-highfive assigned nagisa and unassigned kennytm Sep 24, 2020
@nagisa
Copy link
Member

nagisa commented Sep 26, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 26, 2020

📌 Commit 74952b9 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2020
…as-schievink

Rollup of 10 pull requests

Successful merges:

 - rust-lang#76917 (Add missing code examples on HashMap types)
 - rust-lang#77107 (Enable const propagation into operands at mir_opt_level=2)
 - rust-lang#77129 (Update cargo)
 - rust-lang#77167 (Fix FIXME in core::num test: Check sign of zero in min/max tests.)
 - rust-lang#77184 (Rust vec bench import specific rand::RngCore)
 - rust-lang#77208 (Late link args order)
 - rust-lang#77209 (Fix documentation highlighting in ty::BorrowKind)
 - rust-lang#77231 (Move helper function for `missing_const_for_fn` out of rustc to clippy)
 - rust-lang#77235 (pretty-print-reparse hack: Rename some variables for clarity)
 - rust-lang#77243 (Test more attributes in test issue-75930-derive-cfg.rs)

Failed merges:

r? `@ghost`
@bors bors merged commit 5926c43 into rust-lang:master Sep 27, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 27, 2020
@m-ou-se m-ou-se deleted the fix-fixme-min-max-sign-test branch November 23, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants