Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative extern syntax #77045

Closed
wants to merge 1 commit into from
Closed

Add alternative extern syntax #77045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions compiler/rustc_error_codes/src/error_codes/E0756.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ extern "C" {
#[ffi_const] // ok!
pub fn strlen(s: *const i8) -> i32;
}

#[ffi_pure]
extern "C" pub fn foo() {} // ok!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see what it's adding. :-/

Copy link
Contributor Author

@pickfire pickfire Sep 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative extern syntax I mentioned last time. I didn't know about extern "C" { ... } before this but I only know extern "C" ..., one thing is to let others know that extern could be not a block. But there's a typo here, should be ffi_const.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, it doesn't work. I thought it works.

# fn main() {}
```

Expand Down