Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve doc-comments when generating queries #76820

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Preserve doc-comments when generating queries #76820

merged 1 commit into from
Sep 24, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Sep 17, 2020 •
edited
Loading

Closes #76812

@jyn514 jyn514 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 17, 2020
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2020
@jyn514
Copy link
Member Author

jyn514 commented Sep 17, 2020

Example outputs:
image
image

@jyn514
Preserve doc-comments when generating queries
2f1bfd6 
This also changes some comments into doc-comments.
@jyn514 jyn514 changed the title [WIP] Preserve doc-comments when generating queries Preserve doc-comments when generating queries Sep 17, 2020
@jyn514 jyn514 mentioned this pull request Sep 17, 2020
Merged
@jyn514
Copy link
Member Author

jyn514 commented Sep 24, 2020

Ping @davidtwco - do you have time to take a look at this? It should be a pretty simple review.

@davidtwco
Copy link
Member

Ping @davidtwco - do you have time to take a look at this? It should be a pretty simple review.

Oh, I have no idea how I missed this, will definitely get to this today. Sorry!

davidtwco
davidtwco approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, sorry for being slow on the review. LGTM.

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2020

📌 Commit 2f1bfd6 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2020
@bors
Copy link
Contributor

bors commented Sep 24, 2020

⌛ Testing commit 2f1bfd6 with merge 893fadd...

@bors
Copy link
Contributor

bors commented Sep 24, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: davidtwco
Pushing 893fadd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 24, 2020
@bors bors merged commit 893fadd into rust-lang:master Sep 24, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 24, 2020
@jyn514 jyn514 deleted the query-comments branch September 24, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

Query descriptions aren't rendered in rustdoc documentation
5 participants
@jyn514 @rust-highfive @davidtwco @bors @rustbot