Add error explanation for E0755 #76439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
reviewed
Sep 7, 2020
| extern "C" { | ||
| #[ffi_pure] // ok! | ||
| pub fn strlen(s: *const i8) -> isize; | ||
| } |
There was a problem hiding this comment.
I believe this also work right? Or maybe a better example of this.
#[ffi_pure]
extern "C" pub fn foo() {}There was a problem hiding this comment.
I think it's better to have a bigger contrast. :)
There was a problem hiding this comment.
Oh, I was just suggesting to show both methods so the readers know. Personally I know the second more.
pickfire
reviewed
Sep 7, 2020
Comment on lines
14
to
15
| effects except for their return value. You can find more information about it in | ||
| the [unstable Rust Book]. |
There was a problem hiding this comment.
Suggested change
| effects except for their return value. You can find more information about it in | |
| the [unstable Rust Book]. | |
| side effects or infinite loops. You can find more information about it in the | |
| [unstable Rust Book]. |
Returning value is probably not counted as side effects.
There was a problem hiding this comment.
I quoted the book.
There was a problem hiding this comment.
Yes, I took from the book too.
GuillaumeGomez
force-pushed
the
add-error-explanation-e0755
branch
from
3451bd8 to
69ffed7
Compare
|
Updated! |
|
@bors: r=pickfire,jyn514 rollup |
|
📌 Commit 69ffed7 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 21, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#76439 (Add error explanation for E0755) - rust-lang#76521 (Fix segfault if pthread_getattr_np fails) - rust-lang#76835 (make replace_prefix only take &str as arguments ) - rust-lang#76967 (Revert adding Atomic::from_mut.) - rust-lang#76977 (Add a regression test for copy propagation miscompilation) - rust-lang#76981 (liballoc bench use imported path Bencher) - rust-lang#76983 (BTreeMap: extra testing & fixed comments) - rust-lang#76996 (Fix typo in rustc_lexer docs) - rust-lang#77009 (Dogfood total_cmp in the test crate) - rust-lang#77012 (update Miri for another bugfix) Failed merges: - rust-lang#76489 (Add explanation for E0756) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @pickfire