Clean up E0752 explanation #75482
Clean up E0752 explanation #75482
Conversation
rust-highfive
added
the
S-waiting-on-review
| correctly. To fix it, don't declare the entry point as `async`: | ||
|
|
||
| ``` | ||
| fn main() -> Result<i32, ()> { // ok! | ||
| Ok(1) | ||
| } | ||
| ``` |
There was a problem hiding this comment.
We should put up 3rd party suggestions in case a beginner stumbled up upon this, for example #[tokio::runtime].
There was a problem hiding this comment.
We mention it, but I'm not sure it's a good idea to bring a specific library into a "general" example.
There was a problem hiding this comment.
Where did we mentioned it? I don't quite like bringing a specific library here too but I believe beginners might not understand what is an async runtime, I first heard of the concept async runtime when I use rust so I do think we should point them somewhere. I don't have a good idea how but that is my suggestion.
There was a problem hiding this comment.
I think at this point, the error itself is clear enough. Imagine having an error with smol and seeing this explanation talk about tokio, it would be more confusing than helpful for newcomers I think.
|
Updated! |
|
@bors: r=pickfire rollup |
|
📌 Commit 0ce97fc has been approved by |
bors
added
S-waiting-on-bors
Rollup of 17 pull requests Successful merges: - rust-lang#73943 (Document the unsafe keyword) - rust-lang#74062 (deny(unsafe_op_in_unsafe_fn) in libstd/ffi/c_str.rs) - rust-lang#74185 (Remove liballoc unneeded explicit link) - rust-lang#74192 (Improve documentation on process::Child.std* fields) - rust-lang#74409 (Change Debug impl of SocketAddr and IpAddr to match their Display output) - rust-lang#75195 (BTreeMap: purge innocent use of into_kv_mut) - rust-lang#75214 (Use intra-doc links in `mem::manually_drop` & `mem::maybe_uninit`) - rust-lang#75432 (Switch to intra-doc links in `std::process`) - rust-lang#75482 (Clean up E0752 explanation) - rust-lang#75501 (Move to intra doc links in std::ffi) - rust-lang#75509 (Tweak suggestion for `this` -> `self`) - rust-lang#75511 (Do not emit E0228 when it is implied by E0106) - rust-lang#75515 (Bump std's libc version to 0.2.74) - rust-lang#75517 (Promotion and const interning comments) - rust-lang#75519 (BTreeMap: refactor splitpoint and move testing over to unit test) - rust-lang#75530 (Switch to intra-doc links in os/raw/*.md) - rust-lang#75531 (Migrate unit tests of btree collections to their native breeding ground) Failed merges: r? @ghost
r? @Dylan-DPC
cc @pickfire