allow escaping bound vars when normalizing ty::Opaque
#75443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
eddyb
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
This is what I had in mind (although I missed that the code ended up duplicated like that), but I want @nikomatsakis and/or @matthewjasper to make sure I'm not wrong about my assumptions (see #75313 (comment)).
|
@bors r+ |
|
📌 Commit d2398ee has been approved by |
bors
added
S-waiting-on-bors
lcnr
added
the
beta-nominated
|
@bors p=1 (fixes a |
spastorino
added
the
T-compiler
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced Aug 19, 2020
|
Unilaterally beta-accepting |
pnkfelix
added
the
beta-accepted
Merged
Mark-Simulacrum
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2020
…ulacrum [beta] backports * Fix regionck failure when converting Index to IndexMut rust-lang#74960 * Update RELEASES.md for 1.46.0 rust-lang#74744 * allow escaping bound vars when normalizing `ty::Opaque` rust-lang#75443 r? @ghost
This was referenced Aug 23, 2020
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Add a regression test for issue-72793 Adds a regression test for rust-lang#72793, which is fixed by rust-lang#75443. Note that this won't close the issue as the snippet still shows ICE with `-Zmir-opt-level=2`. But it makes sense to add a test anyway.
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Add a regression test for issue-72793 Adds a regression test for rust-lang#72793, which is fixed by rust-lang#75443. Note that this won't close the issue as the snippet still shows ICE with `-Zmir-opt-level=2`. But it makes sense to add a test anyway.
matklad
added a commit
to matklad/rust
that referenced
this pull request
Sep 4, 2020
Add a regression test for issue-72793 Adds a regression test for rust-lang#72793, which is fixed by rust-lang#75443. Note that this won't close the issue as the snippet still shows ICE with `-Zmir-opt-level=2`. But it makes sense to add a test anyway.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
Add a regression test for issue-72793 Adds a regression test for rust-lang#72793, which is fixed by rust-lang#75443. Note that this won't close the issue as the snippet still shows ICE with `-Zmir-opt-level=2`. But it makes sense to add a test anyway.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
Add a regression test for issue-72793 Adds a regression test for rust-lang#72793, which is fixed by rust-lang#75443. Note that this won't close the issue as the snippet still shows ICE with `-Zmir-opt-level=2`. But it makes sense to add a test anyway.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 5, 2020
Add a regression test for issue-72793 Adds a regression test for rust-lang#72793, which is fixed by rust-lang#75443. Note that this won't close the issue as the snippet still shows ICE with `-Zmir-opt-level=2`. But it makes sense to add a test anyway.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 5, 2020
Add a regression test for issue-72793 Adds a regression test for rust-lang#72793, which is fixed by rust-lang#75443. Note that this won't close the issue as the snippet still shows ICE with `-Zmir-opt-level=2`. But it makes sense to add a test anyway.
lcnr
added a commit
to lcnr/rust
that referenced
this pull request
Oct 26, 2020
This was referenced Oct 26, 2020
lcnr
added a commit
to lcnr/rust
that referenced
this pull request
Nov 2, 2020
Merged
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Nov 6, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2020
…ulacrum [beta] backports This backports a number of PRs to beta: * Add delay_span_bug to no longer ICE rust-lang#78645 * Do not ICE on invalid input rust-lang#78422 * revert rust-lang#75443, update mir validator rust-lang#78410 * Do not try to report on closures to avoid ICE rust-lang#78268 * Disable "optimization to avoid load of address" in InstCombine rust-lang#78195 * Disable MatchBranchSimplification rust-lang#78151 * Do not ICE with TraitPredicates containing [type error] rust-lang#77930 * Tweak `if let` suggestion to be more liberal with suggestion and to not ICE rust-lang#77283 * Use different mirror for linux headers in musl-toolchain CI script. rust-lang#78316
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2020
revert rust-lang#75443, update mir validator This PR reverts rust-lang#75443 to fix rust-lang#75992 and instead uses rust-lang#75419 to fix rust-lang#75313. Adapts rust-lang#75419 to correctly deal with unevaluated constants as otherwise some `feature(const_evaluatable_checked)` tests would ICE. Note that rust-lang#72793 was also fixed by rust-lang#75443, but as that issue only concerns `feature(type_alias_impl_trait)` I deleted that test case for now and would reopen that issue. rust-lang#75443 may have also allowed some other code to now successfully compile which would make this revert a breaking change after 2 stable versions, but I hope that this is a purely theoretical concern. See https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/generator.20upvars/near/214617274 for more reasoning about this. r? `@nikomatsakis` `@eddyb` `@RalfJung`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #75313 (comment) and fixes #75313
cc @eddyb @RalfJung
r? @nikomatsakis