Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable wasm32 tests in CI #75380

Closed

Conversation

Mark-Simulacrum
Copy link
Member

These were previously disabled but the relevant fix in Cargo has
long since landed. The wasm32 builder is hovering at around 35
minutes right now, so we have capacity to do this.

r? @alexcrichton

These were previously disabled but the relevant fix in Cargo has long since
landed.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2020
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Aug 11, 2020

📌 Commit 2c0e1be has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors rollup=iffy

Seems not unlikely to fail in some test or another.

@bors
Copy link
Contributor

bors commented Aug 11, 2020

⌛ Testing commit 2c0e1be with merge 6c0bdf5a7b522df238774cd24dbbc1b2d1466edc...

@bors
Copy link
Contributor

bors commented Aug 11, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2020
@Mark-Simulacrum
Copy link
Member Author

Hm the undefined symbol appears to be core::array::<impl core__convert__AsMut<[T]> for [T; N]>::as_mut (demangled), but AFAICT there's nothing wasm-specific about that function or impl. Any ideas? Perhaps we've seen similar before?

@alexcrichton
Copy link
Member

Doesn't look like anything I'm familiar with at least, but I'm also more familiar with wasi than emscripten.

@Mark-Simulacrum
Copy link
Member Author

Okay I'm going to give this a close and open up an issue as I don't really know how to make progress in that case (nor do I have the time to debug this right now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants