Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest imports of unresolved macros #75209

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Suggest imports of unresolved macros #75209

merged 3 commits into from
Oct 16, 2020

Conversation

hirrolot
Copy link
Contributor

@hirrolot hirrolot commented Aug 6, 2020 •
edited
Loading

Closes #75191.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2020
@hirrolot hirrolot marked this pull request as draft August 6, 2020 05:58
@hirrolot
Copy link
Contributor Author

hirrolot commented Aug 6, 2020

I see that some tests have failed, I'll fix them later.

@petrochenkov petrochenkov self-assigned this Aug 6, 2020
@hirrolot hirrolot marked this pull request as ready for review August 6, 2020 11:21
@petrochenkov petrochenkov removed their assignment Aug 6, 2020
@Dylan-DPC-zz
Copy link

r? @estebank

@bors
Copy link
Contributor

bors commented Aug 30, 2020

☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts.

@jyn514 jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 30, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 7, 2020 •
edited
Loading

This is good to go after a rebase I think? I'd love to have these changes.

@estebank
Copy link
Contributor

Yes, lets rebase and then r=me.

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2020
@JohnCSimon
Copy link
Member

Ping from triage:
@hirrolot can you please rebase this PR and notify estebank?
Thank you.

@hirrolot
Copy link
Contributor Author

@estebank, Have I rebased my PR successfully?

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 30, 2020
@camelid camelid removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2020
@bors
Copy link
Contributor

bors commented Oct 16, 2020

📌 Commit ea7cf61 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2020
@bors
Copy link
Contributor

bors commented Oct 16, 2020

⌛ Testing commit ea7cf61 with merge eeed221c29fba76d85e83f604108fb822a80cb68...

@bors
Copy link
Contributor

bors commented Oct 16, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 16, 2020
@Dylan-DPC-zz Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2020
@Dylan-DPC-zz
Copy link

@bors try

@bors
Copy link
Contributor

bors commented Oct 16, 2020

⌛ Trying commit ea7cf61 with merge 312c870f6acd502520cec1a355ad267e1e57a951...

@bors
Copy link
Contributor

bors commented Oct 16, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 312c870f6acd502520cec1a355ad267e1e57a951 (312c870f6acd502520cec1a355ad267e1e57a951)

@jyn514
Copy link
Member

jyn514 commented Oct 16, 2020 

 curl: (56) OpenSSL SSL_read: Connection was reset, errno 10054

gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now

@bors retry

@bors
Copy link
Contributor

bors commented Oct 16, 2020

⌛ Trying commit ea7cf61 with merge d460900fdbc47f2a0e180679b64ca93d95e6e5e0...

@bors
Copy link
Contributor

bors commented Oct 16, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: d460900fdbc47f2a0e180679b64ca93d95e6e5e0 (d460900fdbc47f2a0e180679b64ca93d95e6e5e0)

@jyn514
Copy link
Member

jyn514 commented Oct 16, 2020

@Dylan-DPC boo, your try messed up bors.

@bors r=estebank

@bors
Copy link
Contributor

bors commented Oct 16, 2020

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: update miri #78023

@bors
Copy link
Contributor

bors commented Oct 16, 2020

📌 Commit ea7cf61 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 16, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 16, 2020
@JohnTitor
Rollup merge of rust-lang#75209 - Hirrolot:suggest-macro-imports, r=e…
72264ef 
…stebank

Suggest imports of unresolved macros

Closes rust-lang#75191.
@JohnTitor JohnTitor mentioned this pull request Oct 16, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Oct 16, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 16, 2020
@bors
Auto merge of rust-lang#78028 - JohnTitor:rollup-jt3hikb, r=JohnTitor
e3051d8 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#75209 (Suggest imports of unresolved macros)
 - rust-lang#77547 (stabilize union with 'ManuallyDrop' fields and 'impl Drop for Union')
 - rust-lang#77827 (Don't link to nightly primitives on stable channel)
 - rust-lang#77855 (resolve: further improvements to "try using the enum's variant" diagnostic)
 - rust-lang#77900 (Use fdatasync for File::sync_data on more OSes)
 - rust-lang#77925 (Suggest minimal subset features in `incomplete_features` lint)
 - rust-lang#77971 (Deny broken intra-doc links in linkchecker)
 - rust-lang#77991 (Bump backtrace-rs)
 - rust-lang#77992 (instrument-coverage: try our best to not ICE)
 - rust-lang#78013 (Fix sidebar scroll on mobile devices)

Failed merges:

r? `@ghost`
@bors bors merged commit 7581bb7 into rust-lang:master Oct 16, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@estebank estebank estebank left review comments

Assignees

@estebank estebank

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

Suggest macro import