Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize Range[Inclusive]::is_empty #75132

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Stabilize Range[Inclusive]::is_empty #75132

merged 2 commits into from
Aug 25, 2020

Commits on Aug 24, 2020

  1. Stabilize Range[Inclusive]::is_empty 

    I would like to propose these two simple methods for stabilization:
- Knowing that a range is exhaused isn't otherwise trivial
- Clippy would like to suggest them, but had to do extra work to disable that path <rust-lang/rust-clippy#3807> because they're unstable
- These work on `PartialOrd`, consistently with now-stable `contains`, and are thus more general than iterator-based approaches that need `Step`
- They've been unchanged for some time, and have picked up uses in the compiler
- Stabilizing them doesn't block any future iterator-based is_empty plans, as the inherent ones are preferred in name resolution
    @scottmcm
    scottmcm committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    c20ad72 View commit details
    Browse the repository at this point in the history

  2. Unbreak the clippy test

    @scottmcm
    scottmcm committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    d6185f9 View commit details
    Browse the repository at this point in the history