-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the discrepancy in the mask type for _mm_shuffle_ps #75009
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Please checkout the submodule at 78891cd instead of the current d6822f9c433bd70f786b157f17beaf64ee28d83a. r=me afterwards. |
@kennytm done :-) |
🤔 could you do a clean rebase? a lot of irrelevant diff is brought in. git fetch origin master
git checkout master
git reset --hard origin/master
cd library/stdarch
git checkout d6822f9c433bd70f786b157f17beaf64ee28d83a
cd -
git add library/stdarch
git commit
git push georgio master --force-with-lease |
Sorry about that, these commits happened by mistake (my first time contributing). |
@bors r+ |
📌 Commit 1e2ce28 has been approved by |
…arth Rollup of 5 pull requests Successful merges: - rust-lang#74980 (pprust: adjust mixed comment printing and add regression test for rust-lang#74745) - rust-lang#75009 (Document the discrepancy in the mask type for _mm_shuffle_ps) - rust-lang#75031 (Do not trigger `unused_{braces,parens}` lints with `yield`) - rust-lang#75059 (fix typos) - rust-lang#75064 (compiletest: Support ignoring tests requiring missing LLVM components) Failed merges: r? @ghost
@kennytm Please don't approve changes that make submodules point to commits that are not part of the target repository's submodule branch. |
Fix broken git commit in stdarch Follow-up on rust-lang#75009, point to the real master commit.
This Pull Request updates the
stdarch
submodule in order to resolve #62490